aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/mm/pageattr_32.c
diff options
context:
space:
mode:
authorAndi Kleen <ak@suse.de>2008-01-30 07:33:52 -0500
committerIngo Molnar <mingo@elte.hu>2008-01-30 07:33:52 -0500
commit895bdc29956e5c9e9e101b2b1c2f0ed34130f945 (patch)
treee95aed8be8660bfac8ca73037cd1e0f0c7e2cdad /arch/x86/mm/pageattr_32.c
parent3c868823413d76bdd80c643603be8ab09dcb4d65 (diff)
x86: c_p_a() make it more robust against use of PAT bits
Use the page table level instead of the PSE bit to check if the PTE is for a 4K page or not. This makes the code more robust when the PAT bit is changed because the PAT bit on 4K pages is in the same position as the PSE bit. Signed-off-by: Andi Kleen <ak@suse.de> Acked-by: Jan Beulich <jbeulich@novell.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/mm/pageattr_32.c')
-rw-r--r--arch/x86/mm/pageattr_32.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/mm/pageattr_32.c b/arch/x86/mm/pageattr_32.c
index 5cb5c7101f41..66688a630839 100644
--- a/arch/x86/mm/pageattr_32.c
+++ b/arch/x86/mm/pageattr_32.c
@@ -172,7 +172,7 @@ static int __change_page_attr(struct page *page, pgprot_t prot)
172 BUG_ON(PageCompound(kpte_page)); 172 BUG_ON(PageCompound(kpte_page));
173 173
174 if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) { 174 if (pgprot_val(prot) != pgprot_val(PAGE_KERNEL)) {
175 if (!pte_huge(*kpte)) { 175 if (level == 3) {
176 set_pte_atomic(kpte, mk_pte(page, prot)); 176 set_pte_atomic(kpte, mk_pte(page, prot));
177 } else { 177 } else {
178 struct page *split; 178 struct page *split;
@@ -190,7 +190,7 @@ static int __change_page_attr(struct page *page, pgprot_t prot)
190 } 190 }
191 page_private(kpte_page)++; 191 page_private(kpte_page)++;
192 } else { 192 } else {
193 if (!pte_huge(*kpte)) { 193 if (level == 3) {
194 set_pte_atomic(kpte, mk_pte(page, PAGE_KERNEL)); 194 set_pte_atomic(kpte, mk_pte(page, PAGE_KERNEL));
195 BUG_ON(page_private(kpte_page) == 0); 195 BUG_ON(page_private(kpte_page) == 0);
196 page_private(kpte_page)--; 196 page_private(kpte_page)--;