diff options
author | Harvey Harrison <harvey.harrison@gmail.com> | 2008-01-30 07:33:13 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:33:13 -0500 |
commit | 6f4d368ef9e9f91aa0019c11e90773ea32d94625 (patch) | |
tree | 9d3ff39d63f50ae779f9964f06efff4eb97cb3da /arch/x86/mm/fault_32.c | |
parent | 608566b4edda5079c7812c2108a89c0fcf2894bb (diff) |
x86: last of trivial fault_32|64.c unification
Comments, indentation, printk format.
Uses task_pid_nr() on X86_64 now, but this is always defined
to task->pid.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/mm/fault_32.c')
-rw-r--r-- | arch/x86/mm/fault_32.c | 20 |
1 files changed, 12 insertions, 8 deletions
diff --git a/arch/x86/mm/fault_32.c b/arch/x86/mm/fault_32.c index 52c13d2e011e..31113deeb7c0 100644 --- a/arch/x86/mm/fault_32.c +++ b/arch/x86/mm/fault_32.c | |||
@@ -36,10 +36,10 @@ | |||
36 | * bit 3 == 1 means use of reserved bit detected | 36 | * bit 3 == 1 means use of reserved bit detected |
37 | * bit 4 == 1 means fault was an instruction fetch | 37 | * bit 4 == 1 means fault was an instruction fetch |
38 | */ | 38 | */ |
39 | #define PF_PROT (1<<0) | 39 | #define PF_PROT (1<<0) |
40 | #define PF_WRITE (1<<1) | 40 | #define PF_WRITE (1<<1) |
41 | #define PF_USER (1<<2) | 41 | #define PF_USER (1<<2) |
42 | #define PF_RSVD (1<<3) | 42 | #define PF_RSVD (1<<3) |
43 | #define PF_INSTR (1<<4) | 43 | #define PF_INSTR (1<<4) |
44 | 44 | ||
45 | static inline int notify_page_fault(struct pt_regs *regs) | 45 | static inline int notify_page_fault(struct pt_regs *regs) |
@@ -460,11 +460,15 @@ bad_area_nosemaphore: | |||
460 | 460 | ||
461 | if (show_unhandled_signals && unhandled_signal(tsk, SIGSEGV) && | 461 | if (show_unhandled_signals && unhandled_signal(tsk, SIGSEGV) && |
462 | printk_ratelimit()) { | 462 | printk_ratelimit()) { |
463 | printk("%s%s[%d]: segfault at %08lx ip %08lx " | 463 | printk( |
464 | "sp %08lx error %lx\n", | 464 | #ifdef CONFIG_X86_32 |
465 | task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG, | 465 | "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n", |
466 | tsk->comm, task_pid_nr(tsk), address, regs->ip, | 466 | #else |
467 | regs->sp, error_code); | 467 | "%s%s[%d]: segfault at %lx ip %lx sp %lx error %lx\n", |
468 | #endif | ||
469 | task_pid_nr(tsk) > 1 ? KERN_INFO : KERN_EMERG, | ||
470 | tsk->comm, task_pid_nr(tsk), address, regs->ip, | ||
471 | regs->sp, error_code); | ||
468 | } | 472 | } |
469 | tsk->thread.cr2 = address; | 473 | tsk->thread.cr2 = address; |
470 | /* Kernel addresses are always protection faults */ | 474 | /* Kernel addresses are always protection faults */ |