x86: clean up esr_disable() methods

Impact: cleanup

Most subarchitectures want to disable the APIC ESR (Error Status Register),
because they generally have hardware hacks that wrap standard CPUs into
a bigger system and hence the APIC bus is quite non-standard and weirdnesses
(lockups) have been seen with ESR reporting.

Remove the esr_disable macros and put the desired flag into each
subarchitecture's genapic template directly.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

5 files changed, 5 insertions, 5 deletions

diff --git a/arch/x86/mach-generic/bigsmp.c b/arch/x86/mach-generic/bigsmp.c
index d3cead2d2fc8..f0bb72674f73 100644
--- a/arch/x86/mach-generic/bigsmp.c
+++ b/arch/x86/mach-generic/bigsmp.c
@@ -69,7 +69,7 @@ struct genapic apic_bigsmp = {
         .irq_dest_mode                  = 0,
 
         .target_cpus                    = bigsmp_target_cpus,
-        .ESR_DISABLE                    = esr_disable,
+        .ESR_DISABLE                    = 1,
         .apic_destination_logical       = APIC_DEST_LOGICAL,
         .check_apicid_used              = check_apicid_used,
         .check_apicid_present           = check_apicid_present,
diff --git a/arch/x86/mach-generic/default.c b/arch/x86/mach-generic/default.c
index a483e22273e5..c30141a9aca0 100644
--- a/arch/x86/mach-generic/default.c
+++ b/arch/x86/mach-generic/default.c
@@ -36,7 +36,7 @@ struct genapic apic_default = {
         .irq_dest_mode                  = 1,
 
         .target_cpus                    = default_target_cpus,
-        .ESR_DISABLE                    = esr_disable,
+        .ESR_DISABLE                    = 0,
         .apic_destination_logical       = APIC_DEST_LOGICAL,
         .check_apicid_used              = check_apicid_used,
         .check_apicid_present           = check_apicid_present,
diff --git a/arch/x86/mach-generic/es7000.c b/arch/x86/mach-generic/es7000.c
index e31f0c35470d..e8aa8fd4f49f 100644
--- a/arch/x86/mach-generic/es7000.c
+++ b/arch/x86/mach-generic/es7000.c
@@ -112,7 +112,7 @@ struct genapic apic_es7000 = {
         .irq_dest_mode                  = 0,
 
         .target_cpus                    = es7000_target_cpus,
-        .ESR_DISABLE                    = esr_disable,
+        .ESR_DISABLE                    = 1,
         .apic_destination_logical       = APIC_DEST_LOGICAL,
         .check_apicid_used              = check_apicid_used,
         .check_apicid_present           = check_apicid_present,
diff --git a/arch/x86/mach-generic/numaq.c b/arch/x86/mach-generic/numaq.c
index 4b84b5970fbe..860edc8bd903 100644
--- a/arch/x86/mach-generic/numaq.c
+++ b/arch/x86/mach-generic/numaq.c
@@ -56,7 +56,7 @@ struct genapic apic_numaq = {
         .irq_dest_mode                  = 0,
 
         .target_cpus                    = numaq_target_cpus,
-        .ESR_DISABLE                    = esr_disable,
+        .ESR_DISABLE                    = 1,
         .apic_destination_logical       = APIC_DEST_LOGICAL,
         .check_apicid_used              = check_apicid_used,
         .check_apicid_present           = check_apicid_present,
diff --git a/arch/x86/mach-generic/summit.c b/arch/x86/mach-generic/summit.c
index e6b956a08484..cd5ef115a4ee 100644
--- a/arch/x86/mach-generic/summit.c
+++ b/arch/x86/mach-generic/summit.c
@@ -49,7 +49,7 @@ struct genapic apic_summit = {
         .irq_dest_mode                  = 1,
 
         .target_cpus                    = summit_target_cpus,
-        .ESR_DISABLE                    = esr_disable,
+        .ESR_DISABLE                    = 1,
         .apic_destination_logical       = APIC_DEST_LOGICAL,
         .check_apicid_used              = check_apicid_used,
         .check_apicid_present           = check_apicid_present,