diff options
author | Marcelo Tosatti <mtosatti@redhat.com> | 2009-01-27 12:12:38 -0500 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2009-03-24 05:03:08 -0400 |
commit | 44882eed2ebe7f75f8cdae5671ab1d6e0fa40dbc (patch) | |
tree | e026a4067370e2dac1a5a3a9d9995e2b6f82ba49 /arch/x86/kvm | |
parent | 934d534f8a5a39e20d5682b3a3a45ff351706b59 (diff) |
KVM: make irq ack notifications aware of routing table
IRQ ack notifications assume an identity mapping between pin->gsi,
which might not be the case with, for example, HPET.
Translate before acking.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Acked-by: Gleb Natapov <gleb@redhat.com>
Diffstat (limited to 'arch/x86/kvm')
-rw-r--r-- | arch/x86/kvm/i8259.c | 5 | ||||
-rw-r--r-- | arch/x86/kvm/irq.h | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c index 179dcb0103fd..93160375c841 100644 --- a/arch/x86/kvm/i8259.c +++ b/arch/x86/kvm/i8259.c | |||
@@ -49,7 +49,8 @@ static void pic_unlock(struct kvm_pic *s) | |||
49 | spin_unlock(&s->lock); | 49 | spin_unlock(&s->lock); |
50 | 50 | ||
51 | while (acks) { | 51 | while (acks) { |
52 | kvm_notify_acked_irq(kvm, __ffs(acks)); | 52 | kvm_notify_acked_irq(kvm, SELECT_PIC(__ffs(acks)), |
53 | __ffs(acks)); | ||
53 | acks &= acks - 1; | 54 | acks &= acks - 1; |
54 | } | 55 | } |
55 | 56 | ||
@@ -232,7 +233,7 @@ int kvm_pic_read_irq(struct kvm *kvm) | |||
232 | } | 233 | } |
233 | pic_update_irq(s); | 234 | pic_update_irq(s); |
234 | pic_unlock(s); | 235 | pic_unlock(s); |
235 | kvm_notify_acked_irq(kvm, irq); | 236 | kvm_notify_acked_irq(kvm, SELECT_PIC(irq), irq); |
236 | 237 | ||
237 | return intno; | 238 | return intno; |
238 | } | 239 | } |
diff --git a/arch/x86/kvm/irq.h b/arch/x86/kvm/irq.h index 82579ee538d0..9f593188129e 100644 --- a/arch/x86/kvm/irq.h +++ b/arch/x86/kvm/irq.h | |||
@@ -32,6 +32,8 @@ | |||
32 | #include "lapic.h" | 32 | #include "lapic.h" |
33 | 33 | ||
34 | #define PIC_NUM_PINS 16 | 34 | #define PIC_NUM_PINS 16 |
35 | #define SELECT_PIC(irq) \ | ||
36 | ((irq) < 8 ? KVM_IRQCHIP_PIC_MASTER : KVM_IRQCHIP_PIC_SLAVE) | ||
35 | 37 | ||
36 | struct kvm; | 38 | struct kvm; |
37 | struct kvm_vcpu; | 39 | struct kvm_vcpu; |