diff options
author | Gleb Natapov <gleb@redhat.com> | 2009-08-24 04:54:26 -0400 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2009-12-03 02:32:08 -0500 |
commit | 680b3648ba89c44ac8d0316f78a0d6e147b88809 (patch) | |
tree | b2b40034c4c33affef8b89822673cca835874651 /arch/x86/kvm/x86.c | |
parent | eba0226bdfffe262e72b8360e4d0d12070e9a0f0 (diff) |
KVM: Drop kvm->irq_lock lock from irq injection path
The only thing it protects now is interrupt injection into lapic and
this can work lockless. Even now with kvm->irq_lock in place access
to lapic is not entirely serialized since vcpu access doesn't take
kvm->irq_lock.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'arch/x86/kvm/x86.c')
-rw-r--r-- | arch/x86/kvm/x86.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index fdf989f17a61..5beb4c16caab 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c | |||
@@ -2286,10 +2286,8 @@ long kvm_arch_vm_ioctl(struct file *filp, | |||
2286 | goto out; | 2286 | goto out; |
2287 | if (irqchip_in_kernel(kvm)) { | 2287 | if (irqchip_in_kernel(kvm)) { |
2288 | __s32 status; | 2288 | __s32 status; |
2289 | mutex_lock(&kvm->irq_lock); | ||
2290 | status = kvm_set_irq(kvm, KVM_USERSPACE_IRQ_SOURCE_ID, | 2289 | status = kvm_set_irq(kvm, KVM_USERSPACE_IRQ_SOURCE_ID, |
2291 | irq_event.irq, irq_event.level); | 2290 | irq_event.irq, irq_event.level); |
2292 | mutex_unlock(&kvm->irq_lock); | ||
2293 | if (ioctl == KVM_IRQ_LINE_STATUS) { | 2291 | if (ioctl == KVM_IRQ_LINE_STATUS) { |
2294 | irq_event.status = status; | 2292 | irq_event.status = status; |
2295 | if (copy_to_user(argp, &irq_event, | 2293 | if (copy_to_user(argp, &irq_event, |