diff options
author | Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> | 2012-10-16 08:10:59 -0400 |
---|---|---|
committer | Marcelo Tosatti <mtosatti@redhat.com> | 2012-10-29 18:31:04 -0400 |
commit | 81c52c56e2b43589091ee29038bcf793d3f184ab (patch) | |
tree | 763236629eb034e519db87d8568946883499a155 /arch/x86/kvm/mmu.c | |
parent | 19bf7f8ac3f8131100027281c495dbbe00cd5ae0 (diff) |
KVM: do not treat noslot pfn as a error pfn
This patch filters noslot pfn out from error pfns based on Marcelo comment:
noslot pfn is not a error pfn
After this patch,
- is_noslot_pfn indicates that the gfn is not in slot
- is_error_pfn indicates that the gfn is in slot but the error is occurred
when translate the gfn to pfn
- is_error_noslot_pfn indicates that the pfn either it is error pfns or it
is noslot pfn
And is_invalid_pfn can be removed, it makes the code more clean
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'arch/x86/kvm/mmu.c')
-rw-r--r-- | arch/x86/kvm/mmu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index aabb1289ff04..b875a9ed9b8e 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c | |||
@@ -2699,7 +2699,7 @@ static void transparent_hugepage_adjust(struct kvm_vcpu *vcpu, | |||
2699 | * PT_PAGE_TABLE_LEVEL and there would be no adjustment done | 2699 | * PT_PAGE_TABLE_LEVEL and there would be no adjustment done |
2700 | * here. | 2700 | * here. |
2701 | */ | 2701 | */ |
2702 | if (!is_error_pfn(pfn) && !kvm_is_mmio_pfn(pfn) && | 2702 | if (!is_error_noslot_pfn(pfn) && !kvm_is_mmio_pfn(pfn) && |
2703 | level == PT_PAGE_TABLE_LEVEL && | 2703 | level == PT_PAGE_TABLE_LEVEL && |
2704 | PageTransCompound(pfn_to_page(pfn)) && | 2704 | PageTransCompound(pfn_to_page(pfn)) && |
2705 | !has_wrprotected_page(vcpu->kvm, gfn, PT_DIRECTORY_LEVEL)) { | 2705 | !has_wrprotected_page(vcpu->kvm, gfn, PT_DIRECTORY_LEVEL)) { |
@@ -2733,7 +2733,7 @@ static bool handle_abnormal_pfn(struct kvm_vcpu *vcpu, gva_t gva, gfn_t gfn, | |||
2733 | bool ret = true; | 2733 | bool ret = true; |
2734 | 2734 | ||
2735 | /* The pfn is invalid, report the error! */ | 2735 | /* The pfn is invalid, report the error! */ |
2736 | if (unlikely(is_invalid_pfn(pfn))) { | 2736 | if (unlikely(is_error_pfn(pfn))) { |
2737 | *ret_val = kvm_handle_bad_page(vcpu, gfn, pfn); | 2737 | *ret_val = kvm_handle_bad_page(vcpu, gfn, pfn); |
2738 | goto exit; | 2738 | goto exit; |
2739 | } | 2739 | } |