diff options
author | Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> | 2008-10-23 20:15:28 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-10-27 09:14:02 -0400 |
commit | fd4a2030a358b4818646031049d9631bd45b9915 (patch) | |
tree | 88b28cac9e5f5bca0a0634ce77530a4c7cf80173 /arch/x86/kernel | |
parent | 709110bd5624094992579f5311541f2e2b7ce58a (diff) |
x86: signal_64.c: get_stack() doesn't need entire regs
Impact: cleanup
get_stack() uses sp only, entire regs is not needed.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel')
-rw-r--r-- | arch/x86/kernel/signal_64.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/arch/x86/kernel/signal_64.c b/arch/x86/kernel/signal_64.c index 9c469da7f9e8..3d0deb336745 100644 --- a/arch/x86/kernel/signal_64.c +++ b/arch/x86/kernel/signal_64.c | |||
@@ -199,12 +199,10 @@ setup_sigcontext(struct sigcontext __user *sc, struct pt_regs *regs, | |||
199 | */ | 199 | */ |
200 | 200 | ||
201 | static void __user * | 201 | static void __user * |
202 | get_stack(struct k_sigaction *ka, struct pt_regs *regs, unsigned long size) | 202 | get_stack(struct k_sigaction *ka, unsigned long sp, unsigned long size) |
203 | { | 203 | { |
204 | unsigned long sp; | ||
205 | |||
206 | /* Default to using normal stack - redzone*/ | 204 | /* Default to using normal stack - redzone*/ |
207 | sp = regs->sp - 128; | 205 | sp -= 128; |
208 | 206 | ||
209 | /* This is the X/Open sanctioned signal stack switching. */ | 207 | /* This is the X/Open sanctioned signal stack switching. */ |
210 | if (ka->sa.sa_flags & SA_ONSTACK) { | 208 | if (ka->sa.sa_flags & SA_ONSTACK) { |
@@ -224,14 +222,14 @@ static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, | |||
224 | struct task_struct *me = current; | 222 | struct task_struct *me = current; |
225 | 223 | ||
226 | if (used_math()) { | 224 | if (used_math()) { |
227 | fp = get_stack(ka, regs, sig_xstate_size); | 225 | fp = get_stack(ka, regs->sp, sig_xstate_size); |
228 | frame = (void __user *)round_down( | 226 | frame = (void __user *)round_down( |
229 | (unsigned long)fp - sizeof(struct rt_sigframe), 16) - 8; | 227 | (unsigned long)fp - sizeof(struct rt_sigframe), 16) - 8; |
230 | 228 | ||
231 | if (save_i387_xstate(fp) < 0) | 229 | if (save_i387_xstate(fp) < 0) |
232 | return -EFAULT; | 230 | return -EFAULT; |
233 | } else | 231 | } else |
234 | frame = get_stack(ka, regs, sizeof(struct rt_sigframe)) - 8; | 232 | frame = get_stack(ka, regs->sp, sizeof(struct rt_sigframe)) - 8; |
235 | 233 | ||
236 | if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame))) | 234 | if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame))) |
237 | return -EFAULT; | 235 | return -EFAULT; |