diff options
author | Michal Schmidt <mschmidt@redhat.com> | 2010-07-27 12:53:35 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2010-08-02 11:45:56 -0400 |
commit | e8c534ec068af1a0845aceda373a9bfd2de62030 (patch) | |
tree | 7ee35fd4b0103c04465c1cc5406f036fc07df53e /arch/x86/kernel | |
parent | 9792db6174d9927700ed288e6d74b9391bf785d1 (diff) |
x86: Fix keeping track of AMD C1E
Accomodate the original C1E-aware idle routine to the different times
during boot when the BIOS enables C1E. While at it, remove the synthetic
CPUID flag in favor of a single global setting which denotes C1E status
on the system.
[ hpa: changed c1e_enabled to be a bool; clarified cpu bit 3:21 comment ]
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
LKML-Reference: <20100727165335.GA11630@aftab>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/kernel')
-rw-r--r-- | arch/x86/kernel/process.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 553b02f13094..b944f89c4e6e 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c | |||
@@ -525,8 +525,10 @@ static int __cpuinit mwait_usable(const struct cpuinfo_x86 *c) | |||
525 | return (edx & MWAIT_EDX_C1); | 525 | return (edx & MWAIT_EDX_C1); |
526 | } | 526 | } |
527 | 527 | ||
528 | bool c1e_detected; | ||
529 | EXPORT_SYMBOL(c1e_detected); | ||
530 | |||
528 | static cpumask_var_t c1e_mask; | 531 | static cpumask_var_t c1e_mask; |
529 | static int c1e_detected; | ||
530 | 532 | ||
531 | void c1e_remove_cpu(int cpu) | 533 | void c1e_remove_cpu(int cpu) |
532 | { | 534 | { |
@@ -548,12 +550,12 @@ static void c1e_idle(void) | |||
548 | u32 lo, hi; | 550 | u32 lo, hi; |
549 | 551 | ||
550 | rdmsr(MSR_K8_INT_PENDING_MSG, lo, hi); | 552 | rdmsr(MSR_K8_INT_PENDING_MSG, lo, hi); |
553 | |||
551 | if (lo & K8_INTP_C1E_ACTIVE_MASK) { | 554 | if (lo & K8_INTP_C1E_ACTIVE_MASK) { |
552 | c1e_detected = 1; | 555 | c1e_detected = true; |
553 | if (!boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) | 556 | if (!boot_cpu_has(X86_FEATURE_NONSTOP_TSC)) |
554 | mark_tsc_unstable("TSC halt in AMD C1E"); | 557 | mark_tsc_unstable("TSC halt in AMD C1E"); |
555 | printk(KERN_INFO "System has AMD C1E enabled\n"); | 558 | printk(KERN_INFO "System has AMD C1E enabled\n"); |
556 | set_cpu_cap(&boot_cpu_data, X86_FEATURE_AMDC1E); | ||
557 | } | 559 | } |
558 | } | 560 | } |
559 | 561 | ||