diff options
author | Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> | 2009-04-30 03:04:51 -0400 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2009-05-28 12:24:16 -0400 |
commit | 14a02530e2239f753a0f3f089847e723adbdaa47 (patch) | |
tree | 3cd21cbc2b627ac37fb2aa480c1b13c6f9152fee /arch/x86/kernel | |
parent | cc3aec52ab8e013984270a79d1aa51f691d239b0 (diff) |
x86, mce: trivial clean up for mce.c
This fixs following checkpatch warnings:
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
+#include <asm/uaccess.h>
WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
+#include <asm/smp.h>
WARNING: line over 80 characters
+ set_bit(MCE_OVERFLOW, (unsigned long *)&mcelog.flags);
WARNING: braces {} are not necessary for any arm of this statement
+ if (mce_notify_user()) {
[...]
+ } else {
[...]
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/kernel')
-rw-r--r-- | arch/x86/kernel/cpu/mcheck/mce.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 4375ffb5459f..1d0aa9c4e15b 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c | |||
@@ -14,6 +14,7 @@ | |||
14 | #include <linux/kallsyms.h> | 14 | #include <linux/kallsyms.h> |
15 | #include <linux/rcupdate.h> | 15 | #include <linux/rcupdate.h> |
16 | #include <linux/kobject.h> | 16 | #include <linux/kobject.h> |
17 | #include <linux/uaccess.h> | ||
17 | #include <linux/kdebug.h> | 18 | #include <linux/kdebug.h> |
18 | #include <linux/kernel.h> | 19 | #include <linux/kernel.h> |
19 | #include <linux/percpu.h> | 20 | #include <linux/percpu.h> |
@@ -27,14 +28,13 @@ | |||
27 | #include <linux/kmod.h> | 28 | #include <linux/kmod.h> |
28 | #include <linux/poll.h> | 29 | #include <linux/poll.h> |
29 | #include <linux/cpu.h> | 30 | #include <linux/cpu.h> |
31 | #include <linux/smp.h> | ||
30 | #include <linux/fs.h> | 32 | #include <linux/fs.h> |
31 | 33 | ||
32 | #include <asm/processor.h> | 34 | #include <asm/processor.h> |
33 | #include <asm/uaccess.h> | ||
34 | #include <asm/idle.h> | 35 | #include <asm/idle.h> |
35 | #include <asm/mce.h> | 36 | #include <asm/mce.h> |
36 | #include <asm/msr.h> | 37 | #include <asm/msr.h> |
37 | #include <asm/smp.h> | ||
38 | 38 | ||
39 | #include "mce.h" | 39 | #include "mce.h" |
40 | 40 | ||
@@ -125,7 +125,8 @@ void mce_log(struct mce *mce) | |||
125 | * interesting ones: | 125 | * interesting ones: |
126 | */ | 126 | */ |
127 | if (entry >= MCE_LOG_LEN) { | 127 | if (entry >= MCE_LOG_LEN) { |
128 | set_bit(MCE_OVERFLOW, (unsigned long *)&mcelog.flags); | 128 | set_bit(MCE_OVERFLOW, |
129 | (unsigned long *)&mcelog.flags); | ||
129 | return; | 130 | return; |
130 | } | 131 | } |
131 | /* Old left over entry. Skip: */ | 132 | /* Old left over entry. Skip: */ |
@@ -556,11 +557,10 @@ static void mcheck_timer(unsigned long data) | |||
556 | * polling interval, otherwise increase the polling interval. | 557 | * polling interval, otherwise increase the polling interval. |
557 | */ | 558 | */ |
558 | n = &__get_cpu_var(next_interval); | 559 | n = &__get_cpu_var(next_interval); |
559 | if (mce_notify_user()) { | 560 | if (mce_notify_user()) |
560 | *n = max(*n/2, HZ/100); | 561 | *n = max(*n/2, HZ/100); |
561 | } else { | 562 | else |
562 | *n = min(*n*2, (int)round_jiffies_relative(check_interval*HZ)); | 563 | *n = min(*n*2, (int)round_jiffies_relative(check_interval*HZ)); |
563 | } | ||
564 | 564 | ||
565 | t->expires = jiffies + *n; | 565 | t->expires = jiffies + *n; |
566 | add_timer(t); | 566 | add_timer(t); |