diff options
author | Glauber de Oliveira Costa <gcosta@redhat.com> | 2008-03-19 13:25:50 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-04-17 11:41:02 -0400 |
commit | e481fcf8563d300e7f8875cae5fdc41941d29de0 (patch) | |
tree | 17e5199c88bcc9b73faa4a487b2caf2532f4b8b1 /arch/x86/kernel/smpboot_32.c | |
parent | ac60aae561fff99d38beba82d84277b12437c05e (diff) |
x86: calibrate delay with irqs enabled
We do it to make it close to x86_64. The later needs it,
otherwise the nmi watchdog can get into the scene and kill us
with a hammer.
Enabling irqs here used to trigger a bug in i386. This is because
time irq handling relies upon structures that are only initialized
after smp initcalls (More precisely, it will find
per_cpu(hrtimer_bases, cpu)->cb_pending list not initialized and crash)
Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/smpboot_32.c')
-rw-r--r-- | arch/x86/kernel/smpboot_32.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/x86/kernel/smpboot_32.c b/arch/x86/kernel/smpboot_32.c index dbfaeb30a69a..bd2f8863efa2 100644 --- a/arch/x86/kernel/smpboot_32.c +++ b/arch/x86/kernel/smpboot_32.c | |||
@@ -167,7 +167,9 @@ static void __cpuinit smp_callin(void) | |||
167 | /* | 167 | /* |
168 | * Get our bogomips. | 168 | * Get our bogomips. |
169 | */ | 169 | */ |
170 | local_irq_enable(); | ||
170 | calibrate_delay(); | 171 | calibrate_delay(); |
172 | local_irq_disable(); | ||
171 | Dprintk("Stack at about %p\n",&cpuid); | 173 | Dprintk("Stack at about %p\n",&cpuid); |
172 | 174 | ||
173 | /* | 175 | /* |