diff options
author | Mike Travis <travis@sgi.com> | 2008-01-30 07:30:55 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:30:55 -0500 |
commit | 7bf0c23ed24b0d95a2a717f86dce1f210e16f8a5 (patch) | |
tree | 64f1d21cfcc7746d430c4ad70c864e176536ac8d /arch/x86/kernel/smp_32.c | |
parent | 0fa376e027f0bd71368e1485f863f0dff8f7c897 (diff) |
x86: prevent dereferencing non-allocated per_cpu variables
'for_each_possible_cpu(i)' when there's a _remote possibility_ of
dereferencing a non-allocated per_cpu variable involved.
All files except mm/vmstat.c are x86 arch.
Thanks to pageexec@freemail.hu for pointing this out.
Signed-off-by: Mike Travis <travis@sgi.com>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: <pageexec@freemail.hu>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/kernel/smp_32.c')
-rw-r--r-- | arch/x86/kernel/smp_32.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/smp_32.c b/arch/x86/kernel/smp_32.c index fcaa026eb807..d4c01a4aca60 100644 --- a/arch/x86/kernel/smp_32.c +++ b/arch/x86/kernel/smp_32.c | |||
@@ -223,7 +223,7 @@ void send_IPI_mask_sequence(cpumask_t mask, int vector) | |||
223 | */ | 223 | */ |
224 | 224 | ||
225 | local_irq_save(flags); | 225 | local_irq_save(flags); |
226 | for (query_cpu = 0; query_cpu < NR_CPUS; ++query_cpu) { | 226 | for_each_possible_cpu(query_cpu) { |
227 | if (cpu_isset(query_cpu, mask)) { | 227 | if (cpu_isset(query_cpu, mask)) { |
228 | __send_IPI_dest_field(cpu_to_logical_apicid(query_cpu), | 228 | __send_IPI_dest_field(cpu_to_logical_apicid(query_cpu), |
229 | vector); | 229 | vector); |
@@ -675,7 +675,7 @@ static int convert_apicid_to_cpu(int apic_id) | |||
675 | { | 675 | { |
676 | int i; | 676 | int i; |
677 | 677 | ||
678 | for (i = 0; i < NR_CPUS; i++) { | 678 | for_each_possible_cpu(i) { |
679 | if (per_cpu(x86_cpu_to_apicid, i) == apic_id) | 679 | if (per_cpu(x86_cpu_to_apicid, i) == apic_id) |
680 | return i; | 680 | return i; |
681 | } | 681 | } |