diff options
author | Don Zickus <dzickus@redhat.com> | 2012-05-11 14:41:15 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2012-05-14 05:49:38 -0400 |
commit | 3aac27aba79b7c52e709ef6de0f7d8139caedc01 (patch) | |
tree | bbe5d70146773045171567b33bc951028c96c112 /arch/x86/kernel/smp.c | |
parent | 7d007d21e539dbecb6942c5734e6649f720982cf (diff) |
x86/reboot: Update nonmi_ipi parameter
Update the nonmi_ipi parameter to reflect the simple change
instead of the previous complicated one. There should be less
of a need to use it but there may still be corner cases on older
hardware that stumble into NMI issues.
Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1336761675-24296-4-git-send-email-dzickus@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'arch/x86/kernel/smp.c')
-rw-r--r-- | arch/x86/kernel/smp.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c index 228e7405511a..48d2b7ded422 100644 --- a/arch/x86/kernel/smp.c +++ b/arch/x86/kernel/smp.c | |||
@@ -110,6 +110,7 @@ | |||
110 | */ | 110 | */ |
111 | 111 | ||
112 | static atomic_t stopping_cpu = ATOMIC_INIT(-1); | 112 | static atomic_t stopping_cpu = ATOMIC_INIT(-1); |
113 | static bool smp_no_nmi_ipi = false; | ||
113 | 114 | ||
114 | /* | 115 | /* |
115 | * this function sends a 'reschedule' IPI to another CPU. | 116 | * this function sends a 'reschedule' IPI to another CPU. |
@@ -216,7 +217,7 @@ static void native_stop_other_cpus(int wait) | |||
216 | } | 217 | } |
217 | 218 | ||
218 | /* if the REBOOT_VECTOR didn't work, try with the NMI */ | 219 | /* if the REBOOT_VECTOR didn't work, try with the NMI */ |
219 | if ((num_online_cpus() > 1)) { | 220 | if ((num_online_cpus() > 1) && (!smp_no_nmi_ipi)) { |
220 | if (register_nmi_handler(NMI_LOCAL, smp_stop_nmi_callback, | 221 | if (register_nmi_handler(NMI_LOCAL, smp_stop_nmi_callback, |
221 | NMI_FLAG_FIRST, "smp_stop")) | 222 | NMI_FLAG_FIRST, "smp_stop")) |
222 | /* Note: we ignore failures here */ | 223 | /* Note: we ignore failures here */ |
@@ -245,11 +246,6 @@ finish: | |||
245 | local_irq_restore(flags); | 246 | local_irq_restore(flags); |
246 | } | 247 | } |
247 | 248 | ||
248 | static void native_smp_disable_nmi_ipi(void) | ||
249 | { | ||
250 | smp_ops.stop_other_cpus = native_irq_stop_other_cpus; | ||
251 | } | ||
252 | |||
253 | /* | 249 | /* |
254 | * Reschedule call back. | 250 | * Reschedule call back. |
255 | */ | 251 | */ |
@@ -283,8 +279,8 @@ void smp_call_function_single_interrupt(struct pt_regs *regs) | |||
283 | 279 | ||
284 | static int __init nonmi_ipi_setup(char *str) | 280 | static int __init nonmi_ipi_setup(char *str) |
285 | { | 281 | { |
286 | native_smp_disable_nmi_ipi(); | 282 | smp_no_nmi_ipi = true; |
287 | return 1; | 283 | return 1; |
288 | } | 284 | } |
289 | 285 | ||
290 | __setup("nonmi_ipi", nonmi_ipi_setup); | 286 | __setup("nonmi_ipi", nonmi_ipi_setup); |