diff options
author | Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> | 2008-12-16 17:02:16 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-12-16 17:06:07 -0500 |
commit | ae417bb487e3bb88dc862b83b4bf00d87ba67ec8 (patch) | |
tree | 99173e7b70ab35532651a4bcd4431a8a8c0875c6 /arch/x86/kernel/signal.c | |
parent | 4217458dafaa57d8e26a46f5d05ab8c53cf64191 (diff) |
x86: signal: use signal_fault() in sys_sigreturn()
Impact: cleanup
Call signal_fault() in error route of sys_sigreturn().
Change log level to KERN_EMERG if current is init.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/signal.c')
-rw-r--r-- | arch/x86/kernel/signal.c | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c index b1cc6da64208..2725a294d734 100644 --- a/arch/x86/kernel/signal.c +++ b/arch/x86/kernel/signal.c | |||
@@ -594,17 +594,7 @@ asmlinkage unsigned long sys_sigreturn(unsigned long __unused) | |||
594 | return ax; | 594 | return ax; |
595 | 595 | ||
596 | badframe: | 596 | badframe: |
597 | if (show_unhandled_signals && printk_ratelimit()) { | 597 | signal_fault(regs, frame, "sigreturn"); |
598 | printk("%s%s[%d] bad frame in sigreturn frame:" | ||
599 | "%p ip:%lx sp:%lx oeax:%lx", | ||
600 | task_pid_nr(current) > 1 ? KERN_INFO : KERN_EMERG, | ||
601 | current->comm, task_pid_nr(current), frame, regs->ip, | ||
602 | regs->sp, regs->orig_ax); | ||
603 | print_vma_addr(" in ", regs->ip); | ||
604 | printk(KERN_CONT "\n"); | ||
605 | } | ||
606 | |||
607 | force_sig(SIGSEGV, current); | ||
608 | 598 | ||
609 | return 0; | 599 | return 0; |
610 | } | 600 | } |
@@ -901,8 +891,9 @@ void signal_fault(struct pt_regs *regs, void __user *frame, char *where) | |||
901 | struct task_struct *me = current; | 891 | struct task_struct *me = current; |
902 | 892 | ||
903 | if (show_unhandled_signals && printk_ratelimit()) { | 893 | if (show_unhandled_signals && printk_ratelimit()) { |
904 | printk(KERN_INFO | 894 | printk("%s" |
905 | "%s[%d] bad frame in %s frame:%p ip:%lx sp:%lx orax:%lx", | 895 | "%s[%d] bad frame in %s frame:%p ip:%lx sp:%lx orax:%lx", |
896 | task_pid_nr(current) > 1 ? KERN_INFO : KERN_EMERG, | ||
906 | me->comm, me->pid, where, frame, | 897 | me->comm, me->pid, where, frame, |
907 | regs->ip, regs->sp, regs->orig_ax); | 898 | regs->ip, regs->sp, regs->orig_ax); |
908 | print_vma_addr(" in ", regs->ip); | 899 | print_vma_addr(" in ", regs->ip); |