diff options
author | Oleg Nesterov <oleg@redhat.com> | 2014-04-19 12:10:09 -0400 |
---|---|---|
committer | Oleg Nesterov <oleg@redhat.com> | 2014-04-30 13:10:35 -0400 |
commit | b24dc8dace74708fd849312722090169c5da97d3 (patch) | |
tree | c668e6b97cd9647b6f8584ee4ccab97417dd93f6 /arch/x86/kernel/process_64.c | |
parent | 8dbacad93a2a12adebcc717e6055b1bcc1739ab8 (diff) |
uprobes/x86: Fix is_64bit_mm() with CONFIG_X86_X32
is_64bit_mm() assumes that mm->context.ia32_compat means the 32-bit
instruction set, this is not true if the task is TIF_X32.
Change set_personality_ia32() to initialize mm->context.ia32_compat
by TIF_X32 or TIF_IA32 instead of 1. This allows to fix is_64bit_mm()
without affecting other users, they all treat ia32_compat as "bool".
TIF_ in ->ia32_compat looks a bit strange, but this is grep-friendly
and avoids the new define's.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Jim Keniston <jkenisto@us.ibm.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'arch/x86/kernel/process_64.c')
-rw-r--r-- | arch/x86/kernel/process_64.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c index 9c0280f93d05..9b53940981b7 100644 --- a/arch/x86/kernel/process_64.c +++ b/arch/x86/kernel/process_64.c | |||
@@ -413,12 +413,11 @@ void set_personality_ia32(bool x32) | |||
413 | set_thread_flag(TIF_ADDR32); | 413 | set_thread_flag(TIF_ADDR32); |
414 | 414 | ||
415 | /* Mark the associated mm as containing 32-bit tasks. */ | 415 | /* Mark the associated mm as containing 32-bit tasks. */ |
416 | if (current->mm) | ||
417 | current->mm->context.ia32_compat = 1; | ||
418 | |||
419 | if (x32) { | 416 | if (x32) { |
420 | clear_thread_flag(TIF_IA32); | 417 | clear_thread_flag(TIF_IA32); |
421 | set_thread_flag(TIF_X32); | 418 | set_thread_flag(TIF_X32); |
419 | if (current->mm) | ||
420 | current->mm->context.ia32_compat = TIF_X32; | ||
422 | current->personality &= ~READ_IMPLIES_EXEC; | 421 | current->personality &= ~READ_IMPLIES_EXEC; |
423 | /* is_compat_task() uses the presence of the x32 | 422 | /* is_compat_task() uses the presence of the x32 |
424 | syscall bit flag to determine compat status */ | 423 | syscall bit flag to determine compat status */ |
@@ -426,6 +425,8 @@ void set_personality_ia32(bool x32) | |||
426 | } else { | 425 | } else { |
427 | set_thread_flag(TIF_IA32); | 426 | set_thread_flag(TIF_IA32); |
428 | clear_thread_flag(TIF_X32); | 427 | clear_thread_flag(TIF_X32); |
428 | if (current->mm) | ||
429 | current->mm->context.ia32_compat = TIF_IA32; | ||
429 | current->personality |= force_personality32; | 430 | current->personality |= force_personality32; |
430 | /* Prepare the first "return" to user space */ | 431 | /* Prepare the first "return" to user space */ |
431 | current_thread_info()->status |= TS_COMPAT; | 432 | current_thread_info()->status |= TS_COMPAT; |