aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kernel/process_64.c
diff options
context:
space:
mode:
authorJan Beulich <jbeulich@novell.com>2008-03-10 09:11:17 -0400
committerIngo Molnar <mingo@elte.hu>2008-04-17 11:40:58 -0400
commit5b0e508415a83989fe704b4718a1a214bc333ca7 (patch)
treebf73f1e6b944c190441413cedfb49b05e04ffe6b /arch/x86/kernel/process_64.c
parentf694010185c429629ad5a65245da08103e611852 (diff)
x86: prevent unconditional writes to DebugCtl MSR
Otherwise, enabling (or better, subsequent disabling) of single stepping would cause a kernel oops on CPUs not having this MSR. The patch could have been added a conditional to the MSR write in user_disable_single_step(), but centralizing the updates seems safer and (looking forward) better manageable. Signed-off-by: Jan Beulich <jbeulich@novell.com> Cc: Markus Metzger <markus.t.metzger@intel.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/process_64.c')
-rw-r--r--arch/x86/kernel/process_64.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index 1ffce14cff6e..4f40272474dd 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -563,12 +563,12 @@ static inline void __switch_to_xtra(struct task_struct *prev_p,
563 /* we clear debugctl to make sure DS 563 /* we clear debugctl to make sure DS
564 * is not in use when we change it */ 564 * is not in use when we change it */
565 debugctl = 0; 565 debugctl = 0;
566 wrmsrl(MSR_IA32_DEBUGCTLMSR, 0); 566 update_debugctlmsr(0);
567 wrmsrl(MSR_IA32_DS_AREA, next->ds_area_msr); 567 wrmsrl(MSR_IA32_DS_AREA, next->ds_area_msr);
568 } 568 }
569 569
570 if (next->debugctlmsr != debugctl) 570 if (next->debugctlmsr != debugctl)
571 wrmsrl(MSR_IA32_DEBUGCTLMSR, next->debugctlmsr); 571 update_debugctlmsr(next->debugctlmsr);
572 572
573 if (test_tsk_thread_flag(next_p, TIF_DEBUG)) { 573 if (test_tsk_thread_flag(next_p, TIF_DEBUG)) {
574 loaddebug(next, 0); 574 loaddebug(next, 0);