diff options
author | Jan Beulich <jbeulich@novell.com> | 2008-03-10 09:11:17 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-04-17 11:40:58 -0400 |
commit | 5b0e508415a83989fe704b4718a1a214bc333ca7 (patch) | |
tree | bf73f1e6b944c190441413cedfb49b05e04ffe6b /arch/x86/kernel/process_32.c | |
parent | f694010185c429629ad5a65245da08103e611852 (diff) |
x86: prevent unconditional writes to DebugCtl MSR
Otherwise, enabling (or better, subsequent disabling) of single
stepping would cause a kernel oops on CPUs not having this MSR.
The patch could have been added a conditional to the MSR write in
user_disable_single_step(), but centralizing the updates seems safer
and (looking forward) better manageable.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Markus Metzger <markus.t.metzger@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/process_32.c')
-rw-r--r-- | arch/x86/kernel/process_32.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index 9230ce060d09..ec05fb750dfc 100644 --- a/arch/x86/kernel/process_32.c +++ b/arch/x86/kernel/process_32.c | |||
@@ -564,12 +564,12 @@ __switch_to_xtra(struct task_struct *prev_p, struct task_struct *next_p, | |||
564 | /* we clear debugctl to make sure DS | 564 | /* we clear debugctl to make sure DS |
565 | * is not in use when we change it */ | 565 | * is not in use when we change it */ |
566 | debugctl = 0; | 566 | debugctl = 0; |
567 | wrmsrl(MSR_IA32_DEBUGCTLMSR, 0); | 567 | update_debugctlmsr(0); |
568 | wrmsr(MSR_IA32_DS_AREA, next->ds_area_msr, 0); | 568 | wrmsr(MSR_IA32_DS_AREA, next->ds_area_msr, 0); |
569 | } | 569 | } |
570 | 570 | ||
571 | if (next->debugctlmsr != debugctl) | 571 | if (next->debugctlmsr != debugctl) |
572 | wrmsr(MSR_IA32_DEBUGCTLMSR, next->debugctlmsr, 0); | 572 | update_debugctlmsr(next->debugctlmsr); |
573 | 573 | ||
574 | if (test_tsk_thread_flag(next_p, TIF_DEBUG)) { | 574 | if (test_tsk_thread_flag(next_p, TIF_DEBUG)) { |
575 | set_debugreg(next->debugreg0, 0); | 575 | set_debugreg(next->debugreg0, 0); |