diff options
author | Alex Nixon <alex.nixon@citrix.com> | 2008-08-22 06:52:12 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-08-25 04:59:18 -0400 |
commit | 379002586368ae22916f668011c9118c8ce8189c (patch) | |
tree | 875144461ee68d5c960061c202d6ddc01750ee82 /arch/x86/kernel/process_32.c | |
parent | 93be71b672f167b1e8c23725114f86305354f0ac (diff) |
x86_32: clean up play_dead
The removal of the CPU from the various maps was redundant as it already
happened in cpu_disable.
After cleaning this up, cpu_uninit only resets the tlb state, so rename
it and create a noop version for the X86_64 case (so the two play_deads
can be unified later).
Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/process_32.c')
-rw-r--r-- | arch/x86/kernel/process_32.c | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index e382fe0ccd66..d55eb49584b1 100644 --- a/arch/x86/kernel/process_32.c +++ b/arch/x86/kernel/process_32.c | |||
@@ -75,26 +75,17 @@ unsigned long thread_saved_pc(struct task_struct *tsk) | |||
75 | #ifdef CONFIG_HOTPLUG_CPU | 75 | #ifdef CONFIG_HOTPLUG_CPU |
76 | #include <asm/nmi.h> | 76 | #include <asm/nmi.h> |
77 | 77 | ||
78 | static void cpu_exit_clear(void) | 78 | /* We don't actually take CPU down, just spin without interrupts. */ |
79 | void native_play_dead(void) | ||
79 | { | 80 | { |
80 | int cpu = raw_smp_processor_id(); | 81 | int cpu = raw_smp_processor_id(); |
81 | 82 | ||
82 | idle_task_exit(); | 83 | idle_task_exit(); |
83 | 84 | ||
84 | cpu_uninit(); | 85 | reset_lazy_tlbstate(); |
85 | irq_ctx_exit(cpu); | ||
86 | 86 | ||
87 | cpu_clear(cpu, cpu_callout_map); | 87 | irq_ctx_exit(cpu); |
88 | cpu_clear(cpu, cpu_callin_map); | ||
89 | |||
90 | numa_remove_cpu(cpu); | ||
91 | } | ||
92 | 88 | ||
93 | /* We don't actually take CPU down, just spin without interrupts. */ | ||
94 | void native_play_dead(void) | ||
95 | { | ||
96 | /* This must be done before dead CPU ack */ | ||
97 | cpu_exit_clear(); | ||
98 | mb(); | 89 | mb(); |
99 | /* Ack it */ | 90 | /* Ack it */ |
100 | __get_cpu_var(cpu_state) = CPU_DEAD; | 91 | __get_cpu_var(cpu_state) = CPU_DEAD; |