aboutsummaryrefslogtreecommitdiffstats
path: root/arch/x86/kernel/process.c
diff options
context:
space:
mode:
authorThomas Renninger <trenn@suse.de>2010-04-20 07:17:36 -0400
committerDave Jones <davej@redhat.com>2010-08-03 13:47:05 -0400
commit6f4f2723d08534fd4e407e1ef8500b0f4d12c30c (patch)
tree3422ba34e7c6bde7e8d4ca1f1f1ed772efc5cc4c /arch/x86/kernel/process.c
parent6b72e3934b42930fd40fc42fe762d21be413301c (diff)
[CPUFREQ] x86 cpufreq: Make trace_power_frequency cpufreq driver independent
and fix the broken case if a core's frequency depends on others. trace_power_frequency was only implemented in a rather ungeneric way in acpi-cpufreq driver's target() function only. -> Move the call to trace_power_frequency to cpufreq.c:cpufreq_notify_transition() where CPUFREQ_POSTCHANGE notifier is triggered. This will support power frequency tracing by all cpufreq drivers trace_power_frequency did not trace frequency changes correctly when the userspace governor was used or when CPU cores' frequency depend on each other. -> Moving this into the CPUFREQ_POSTCHANGE notifier and pass the cpu which gets switched automatically fixes this. Robert Schoene provided some important fixes on top of my initial quick shot version which are integrated in this patch: - Forgot some changes in power_end trace (TP_printk/variable names) - Variable dummy in power_end must now be cpu_id - Use static 64 bit variable instead of unsigned int for cpu_id Signed-off-by: Thomas Renninger <trenn@suse.de> CC: davej@redhat.com CC: arjan@infradead.org CC: linux-kernel@vger.kernel.org CC: robert.schoene@tu-dresden.de Tested-by: robert.schoene@tu-dresden.de Signed-off-by: Dave Jones <davej@redhat.com>
Diffstat (limited to 'arch/x86/kernel/process.c')
-rw-r--r--arch/x86/kernel/process.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index e7e35219b32f..787572d43d9c 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -371,7 +371,7 @@ static inline int hlt_use_halt(void)
371void default_idle(void) 371void default_idle(void)
372{ 372{
373 if (hlt_use_halt()) { 373 if (hlt_use_halt()) {
374 trace_power_start(POWER_CSTATE, 1); 374 trace_power_start(POWER_CSTATE, 1, smp_processor_id());
375 current_thread_info()->status &= ~TS_POLLING; 375 current_thread_info()->status &= ~TS_POLLING;
376 /* 376 /*
377 * TS_POLLING-cleared state must be visible before we 377 * TS_POLLING-cleared state must be visible before we
@@ -441,7 +441,7 @@ EXPORT_SYMBOL_GPL(cpu_idle_wait);
441 */ 441 */
442void mwait_idle_with_hints(unsigned long ax, unsigned long cx) 442void mwait_idle_with_hints(unsigned long ax, unsigned long cx)
443{ 443{
444 trace_power_start(POWER_CSTATE, (ax>>4)+1); 444 trace_power_start(POWER_CSTATE, (ax>>4)+1, smp_processor_id());
445 if (!need_resched()) { 445 if (!need_resched()) {
446 if (cpu_has(&current_cpu_data, X86_FEATURE_CLFLUSH_MONITOR)) 446 if (cpu_has(&current_cpu_data, X86_FEATURE_CLFLUSH_MONITOR))
447 clflush((void *)&current_thread_info()->flags); 447 clflush((void *)&current_thread_info()->flags);
@@ -457,7 +457,7 @@ void mwait_idle_with_hints(unsigned long ax, unsigned long cx)
457static void mwait_idle(void) 457static void mwait_idle(void)
458{ 458{
459 if (!need_resched()) { 459 if (!need_resched()) {
460 trace_power_start(POWER_CSTATE, 1); 460 trace_power_start(POWER_CSTATE, 1, smp_processor_id());
461 if (cpu_has(&current_cpu_data, X86_FEATURE_CLFLUSH_MONITOR)) 461 if (cpu_has(&current_cpu_data, X86_FEATURE_CLFLUSH_MONITOR))
462 clflush((void *)&current_thread_info()->flags); 462 clflush((void *)&current_thread_info()->flags);
463 463
@@ -478,7 +478,7 @@ static void mwait_idle(void)
478 */ 478 */
479static void poll_idle(void) 479static void poll_idle(void)
480{ 480{
481 trace_power_start(POWER_CSTATE, 0); 481 trace_power_start(POWER_CSTATE, 0, smp_processor_id());
482 local_irq_enable(); 482 local_irq_enable();
483 while (!need_resched()) 483 while (!need_resched())
484 cpu_relax(); 484 cpu_relax();