diff options
author | Cyrill Gorcunov <gorcunov@gmail.com> | 2008-06-24 16:52:05 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-07-08 06:51:41 -0400 |
commit | c376d45432d935e6f1e0ff2d6be3734bcd3ba455 (patch) | |
tree | c776405c9734a11e6947b55cd2c44e4d7ec1fcfb /arch/x86/kernel/io_apic_64.c | |
parent | 2b6addad2d67a2d75ae10a1c8efd18d81d78ff82 (diff) |
x86: nmi_watchdog - use NMI_NONE by default
There is no need to keep NMI_DISABLED definition and use it
for nmi_watchdog by default. Here is the point why:
- IO-APIC and APIC chips are programmed for nmi_watchdog support at very
early stage of kernel booting and not having nmi_watchdog specified as
boot option lead only to nmi_watchdog becomes to NMI_NONE anyway
- enable nmi_watchdog thru /proc/sys/kernel/nmi if it was not specified at
boot is not possible too (even having this sysfs entry)
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: macro@linux-mips.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/io_apic_64.c')
-rw-r--r-- | arch/x86/kernel/io_apic_64.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c index 08c48750888a..2b4c40bc12c9 100644 --- a/arch/x86/kernel/io_apic_64.c +++ b/arch/x86/kernel/io_apic_64.c | |||
@@ -1729,7 +1729,6 @@ static inline void __init check_timer(void) | |||
1729 | } | 1729 | } |
1730 | unmask_IO_APIC_irq(0); | 1730 | unmask_IO_APIC_irq(0); |
1731 | if (!no_timer_check && timer_irq_works()) { | 1731 | if (!no_timer_check && timer_irq_works()) { |
1732 | nmi_watchdog_default(); | ||
1733 | if (nmi_watchdog == NMI_IO_APIC) { | 1732 | if (nmi_watchdog == NMI_IO_APIC) { |
1734 | setup_nmi(); | 1733 | setup_nmi(); |
1735 | enable_8259A_irq(0); | 1734 | enable_8259A_irq(0); |
@@ -1758,7 +1757,6 @@ static inline void __init check_timer(void) | |||
1758 | if (timer_irq_works()) { | 1757 | if (timer_irq_works()) { |
1759 | apic_printk(APIC_VERBOSE," works.\n"); | 1758 | apic_printk(APIC_VERBOSE," works.\n"); |
1760 | timer_through_8259 = 1; | 1759 | timer_through_8259 = 1; |
1761 | nmi_watchdog_default(); | ||
1762 | if (nmi_watchdog == NMI_IO_APIC) { | 1760 | if (nmi_watchdog == NMI_IO_APIC) { |
1763 | disable_8259A_irq(0); | 1761 | disable_8259A_irq(0); |
1764 | setup_nmi(); | 1762 | setup_nmi(); |