diff options
author | Jan Beulich <jbeulich@novell.com> | 2008-01-30 07:31:24 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 07:31:24 -0500 |
commit | e94271017f0933b29362a3c9dea5a6b9d04d98e1 (patch) | |
tree | e3711fd58a2a6f12a6b09087832468776e3c19e3 /arch/x86/kernel/io_apic_64.c | |
parent | cae4595764cb3b08f6517e99bac1e3862854b1a1 (diff) |
x86: adjust enable_NMI_through_LVT0()
Its previous use in a call to on_each_cpu() was pointless, as at the
time that code gets executed only one CPU is online. Further, the
function can be __cpuinit, and for this to work without
CONFIG_HOTPLUG_CPU setup_nmi() must also get an attribute (this one
can even be __init; on 64-bits check_timer() also was lacking that
attribute).
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/kernel/io_apic_64.c')
-rw-r--r-- | arch/x86/kernel/io_apic_64.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/x86/kernel/io_apic_64.c b/arch/x86/kernel/io_apic_64.c index fa70005be5e8..f914d84a21da 100644 --- a/arch/x86/kernel/io_apic_64.c +++ b/arch/x86/kernel/io_apic_64.c | |||
@@ -1566,7 +1566,7 @@ static struct hw_interrupt_type lapic_irq_type __read_mostly = { | |||
1566 | .end = end_lapic_irq, | 1566 | .end = end_lapic_irq, |
1567 | }; | 1567 | }; |
1568 | 1568 | ||
1569 | static void setup_nmi (void) | 1569 | static void __init setup_nmi(void) |
1570 | { | 1570 | { |
1571 | /* | 1571 | /* |
1572 | * Dirty trick to enable the NMI watchdog ... | 1572 | * Dirty trick to enable the NMI watchdog ... |
@@ -1579,7 +1579,7 @@ static void setup_nmi (void) | |||
1579 | */ | 1579 | */ |
1580 | printk(KERN_INFO "activating NMI Watchdog ..."); | 1580 | printk(KERN_INFO "activating NMI Watchdog ..."); |
1581 | 1581 | ||
1582 | enable_NMI_through_LVT0(NULL); | 1582 | enable_NMI_through_LVT0(); |
1583 | 1583 | ||
1584 | printk(" done.\n"); | 1584 | printk(" done.\n"); |
1585 | } | 1585 | } |
@@ -1655,7 +1655,7 @@ static inline void unlock_ExtINT_logic(void) | |||
1655 | * | 1655 | * |
1656 | * FIXME: really need to revamp this for modern platforms only. | 1656 | * FIXME: really need to revamp this for modern platforms only. |
1657 | */ | 1657 | */ |
1658 | static inline void check_timer(void) | 1658 | static inline void __init check_timer(void) |
1659 | { | 1659 | { |
1660 | struct irq_cfg *cfg = irq_cfg + 0; | 1660 | struct irq_cfg *cfg = irq_cfg + 0; |
1661 | int apic1, pin1, apic2, pin2; | 1661 | int apic1, pin1, apic2, pin2; |