x86: clean up genapic_phys_flat

- reorder fields so that they appear in struct genapic field ordering

- add zero-initialized fields too so that it's apparent which functionality
  is default / missing.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

1 files changed, 56 insertions, 19 deletions

diff --git a/arch/x86/kernel/genapic_flat_64.c b/arch/x86/kernel/genapic_flat_64.c
index f1bfdd3608a8..e9233374cef1 100644
--- a/arch/x86/kernel/genapic_flat_64.c
+++ b/arch/x86/kernel/genapic_flat_64.c
@@ -320,23 +320,60 @@ physflat_cpu_mask_to_apicid_and(const struct cpumask *cpumask,
 }
 
 struct genapic apic_physflat =  {
-        .name = "physical flat",
-        .acpi_madt_oem_check = physflat_acpi_madt_oem_check,
-        .int_delivery_mode = dest_Fixed,
-        .int_dest_mode = (APIC_DEST_PHYSICAL != 0),
-        .target_cpus = physflat_target_cpus,
-        .vector_allocation_domain = physflat_vector_allocation_domain,
-        .apic_id_registered = flat_apic_id_registered,
-        .init_apic_ldr = flat_init_apic_ldr,/*not needed, but shouldn't hurt*/
-        .send_IPI_all = physflat_send_IPI_all,
-        .send_IPI_allbutself = physflat_send_IPI_allbutself,
-        .send_IPI_mask = physflat_send_IPI_mask,
-        .send_IPI_mask_allbutself = physflat_send_IPI_mask_allbutself,
-        .send_IPI_self = apic_send_IPI_self,
-        .cpu_mask_to_apicid = physflat_cpu_mask_to_apicid,
-        .cpu_mask_to_apicid_and = physflat_cpu_mask_to_apicid_and,
-        .phys_pkg_id = phys_pkg_id,
-        .get_apic_id = get_apic_id,
-        .set_apic_id = set_apic_id,
-        .apic_id_mask = (0xFFu<<24),
+
+        .name                           = "physical flat",
+        .probe                          = NULL,
+        .acpi_madt_oem_check            = physflat_acpi_madt_oem_check,
+        .apic_id_registered             = flat_apic_id_registered,
+
+        .int_delivery_mode              = dest_Fixed,
+        .int_dest_mode                  = (APIC_DEST_PHYSICAL != 0),
+
+        .target_cpus                    = physflat_target_cpus,
+        .ESR_DISABLE                    = 0,
+        .apic_destination_logical       = 0,
+        .check_apicid_used              = NULL,
+        .check_apicid_present           = NULL,
+
+        .no_balance_irq                 = 0,
+        .no_ioapic_check                = 0,
+
+        .vector_allocation_domain       = physflat_vector_allocation_domain,
+        /* not needed, but shouldn't hurt: */
+        .init_apic_ldr                  = flat_init_apic_ldr,
+
+        .ioapic_phys_id_map             = NULL,
+        .setup_apic_routing             = NULL,
+        .multi_timer_check              = NULL,
+        .apicid_to_node                 = NULL,
+        .cpu_to_logical_apicid          = NULL,
+        .cpu_present_to_apicid          = NULL,
+        .apicid_to_cpu_present          = NULL,
+        .setup_portio_remap             = NULL,
+        .check_phys_apicid_present      = NULL,
+        .enable_apic_mode               = NULL,
+        .phys_pkg_id                    = phys_pkg_id,
+        .mps_oem_check                  = NULL,
+
+        .get_apic_id                    = get_apic_id,
+        .set_apic_id                    = set_apic_id,
+        .apic_id_mask                   = 0xFFu<<24,
+
+        .cpu_mask_to_apicid             = physflat_cpu_mask_to_apicid,
+        .cpu_mask_to_apicid_and         = physflat_cpu_mask_to_apicid_and,
+
+        .send_IPI_mask                  = physflat_send_IPI_mask,
+        .send_IPI_mask_allbutself       = physflat_send_IPI_mask_allbutself,
+        .send_IPI_allbutself            = physflat_send_IPI_allbutself,
+        .send_IPI_all                   = physflat_send_IPI_all,
+        .send_IPI_self                  = apic_send_IPI_self,
+
+        .wakeup_cpu                     = NULL,
+        .trampoline_phys_low            = 0,
+        .trampoline_phys_high           = 0,
+        .wait_for_init_deassert         = NULL,
+        .smp_callin_clear_local_apic    = NULL,
+        .store_NMI_vector               = NULL,
+        .restore_NMI_vector             = NULL,
+        .inquire_remote_apic            = NULL,
 };