diff options
author | H. Peter Anvin <hpa@zytor.com> | 2012-02-19 10:56:26 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2012-02-20 15:52:05 -0500 |
commit | fca460f95e928bae373daa8295877b6905bc62b8 (patch) | |
tree | 96247518911543b252f4a79cfdf578001473ff3d /arch/x86/kernel/entry_64.S | |
parent | 9d3897630e14b3d33bcb24a3c0fa9d60a01d3058 (diff) |
x32: Handle the x32 system call flag
x32 shares most system calls with x86-64, but unfortunately some
subsystem (the input subsystem is the chief offender) which require
is_compat() when operating with a 32-bit userspace. The input system
actually has text files in sysfs whose meaning is dependent on
sizeof(long) in userspace!
We could solve this by having two completely disjoint system call
tables; requiring that each system call be duplicated. This patch
takes a different approach: we add a flag to the system call number;
this flag doesn't affect the system call dispatch but requests compat
treatment from affected subsystems for the duration of the system call.
The change of cmpq to cmpl is safe since it immediately follows the
and.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/kernel/entry_64.S')
-rw-r--r-- | arch/x86/kernel/entry_64.S | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S index 3fe8239fd8fb..a17b34216971 100644 --- a/arch/x86/kernel/entry_64.S +++ b/arch/x86/kernel/entry_64.S | |||
@@ -482,7 +482,12 @@ GLOBAL(system_call_after_swapgs) | |||
482 | testl $_TIF_WORK_SYSCALL_ENTRY,TI_flags+THREAD_INFO(%rsp,RIP-ARGOFFSET) | 482 | testl $_TIF_WORK_SYSCALL_ENTRY,TI_flags+THREAD_INFO(%rsp,RIP-ARGOFFSET) |
483 | jnz tracesys | 483 | jnz tracesys |
484 | system_call_fastpath: | 484 | system_call_fastpath: |
485 | #if __SYSCALL_MASK == ~0 | ||
485 | cmpq $__NR_syscall_max,%rax | 486 | cmpq $__NR_syscall_max,%rax |
487 | #else | ||
488 | andl $__SYSCALL_MASK,%eax | ||
489 | cmpl $__NR_syscall_max,%eax | ||
490 | #endif | ||
486 | ja badsys | 491 | ja badsys |
487 | movq %r10,%rcx | 492 | movq %r10,%rcx |
488 | call *sys_call_table(,%rax,8) # XXX: rip relative | 493 | call *sys_call_table(,%rax,8) # XXX: rip relative |
@@ -596,7 +601,12 @@ tracesys: | |||
596 | */ | 601 | */ |
597 | LOAD_ARGS ARGOFFSET, 1 | 602 | LOAD_ARGS ARGOFFSET, 1 |
598 | RESTORE_REST | 603 | RESTORE_REST |
604 | #if __SYSCALL_MASK == ~0 | ||
599 | cmpq $__NR_syscall_max,%rax | 605 | cmpq $__NR_syscall_max,%rax |
606 | #else | ||
607 | andl $__SYSCALL_MASK,%eax | ||
608 | cmpl $__NR_syscall_max,%eax | ||
609 | #endif | ||
600 | ja int_ret_from_sys_call /* RAX(%rsp) set to -ENOSYS above */ | 610 | ja int_ret_from_sys_call /* RAX(%rsp) set to -ENOSYS above */ |
601 | movq %r10,%rcx /* fixup for C */ | 611 | movq %r10,%rcx /* fixup for C */ |
602 | call *sys_call_table(,%rax,8) | 612 | call *sys_call_table(,%rax,8) |