diff options
author | Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> | 2009-12-02 21:33:08 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@zytor.com> | 2009-12-03 00:27:32 -0500 |
commit | fe5ed91ddce85a0ed0e4f92c10b099873ef62167 (patch) | |
tree | 3ca148c39006ea48496a4a077a09bbe7a4dd6939 /arch/x86/kernel/cpu | |
parent | b8b7d791a8ff01d2380089279a69afa99115fb23 (diff) |
x86, mce: don't restart timer if disabled
Even it is in error path unlikely taken, add_timer_on() at
CPU_DOWN_FAILED* needs to be skipped if mce_timer is disabled.
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Jan Beulich <jbeulich@novell.com>
Cc: <stable@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/kernel/cpu')
-rw-r--r-- | arch/x86/kernel/cpu/mcheck/mce.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 721a77ca8115..4825a3d6eb40 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c | |||
@@ -1991,9 +1991,11 @@ mce_cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu) | |||
1991 | break; | 1991 | break; |
1992 | case CPU_DOWN_FAILED: | 1992 | case CPU_DOWN_FAILED: |
1993 | case CPU_DOWN_FAILED_FROZEN: | 1993 | case CPU_DOWN_FAILED_FROZEN: |
1994 | t->expires = round_jiffies(jiffies + | 1994 | if (!mce_ignore_ce && check_interval) { |
1995 | t->expires = round_jiffies(jiffies + | ||
1995 | __get_cpu_var(mce_next_interval)); | 1996 | __get_cpu_var(mce_next_interval)); |
1996 | add_timer_on(t, cpu); | 1997 | add_timer_on(t, cpu); |
1998 | } | ||
1997 | smp_call_function_single(cpu, mce_reenable_cpu, &action, 1); | 1999 | smp_call_function_single(cpu, mce_reenable_cpu, &action, 1); |
1998 | break; | 2000 | break; |
1999 | case CPU_POST_DEAD: | 2001 | case CPU_POST_DEAD: |