diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2010-10-19 08:50:02 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2010-10-22 08:18:26 -0400 |
commit | f80c9e304b8e8062230b0cda2c2fdd586149c771 (patch) | |
tree | 5f6ec4a103e49744f822ed43f6a0090b38c13354 /arch/x86/kernel/cpu/perf_event.c | |
parent | 6809b6ea73f7291f2e495d40397f1172c9caa77e (diff) |
perf, x86: Clean up reserve_ds_buffers() signature
Now that reserve_ds_buffers() never fails, change it to return
void and remove all code dealing with the error return.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Stephane Eranian <eranian@google.com>
LKML-Reference: <20101019134808.462621937@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/cpu/perf_event.c')
-rw-r--r-- | arch/x86/kernel/cpu/perf_event.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c index 61e78f651060..a333bf9189f6 100644 --- a/arch/x86/kernel/cpu/perf_event.c +++ b/arch/x86/kernel/cpu/perf_event.c | |||
@@ -382,7 +382,7 @@ static void release_pmc_hardware(void) {} | |||
382 | 382 | ||
383 | #endif | 383 | #endif |
384 | 384 | ||
385 | static int reserve_ds_buffers(void); | 385 | static void reserve_ds_buffers(void); |
386 | static void release_ds_buffers(void); | 386 | static void release_ds_buffers(void); |
387 | 387 | ||
388 | static void hw_perf_event_destroy(struct perf_event *event) | 388 | static void hw_perf_event_destroy(struct perf_event *event) |
@@ -546,11 +546,8 @@ static int __x86_pmu_event_init(struct perf_event *event) | |||
546 | if (atomic_read(&active_events) == 0) { | 546 | if (atomic_read(&active_events) == 0) { |
547 | if (!reserve_pmc_hardware()) | 547 | if (!reserve_pmc_hardware()) |
548 | err = -EBUSY; | 548 | err = -EBUSY; |
549 | else { | 549 | else |
550 | err = reserve_ds_buffers(); | 550 | reserve_ds_buffers(); |
551 | if (err) | ||
552 | release_pmc_hardware(); | ||
553 | } | ||
554 | } | 551 | } |
555 | if (!err) | 552 | if (!err) |
556 | atomic_inc(&active_events); | 553 | atomic_inc(&active_events); |