diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-06-03 16:19:36 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-06-03 17:39:51 -0400 |
commit | 128f048f0f0d2a477ad2555e7acd2ad15a1b6061 (patch) | |
tree | 5927a26da343af2189e47b497eec38680f19294f /arch/x86/kernel/cpu/perf_counter.c | |
parent | 233f0b95ca3a0d1dcbd70bc7e519069a8e10d23e (diff) |
perf_counter: Fix throttling lock-up
Throttling logic is broken and we can lock up with too small
hw sampling intervals.
Make the throttling code more robust: disable counters even
if we already disabled them.
( Also clean up whitespace damage i noticed while reading
various pieces of code related to throttling. )
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/cpu/perf_counter.c')
-rw-r--r-- | arch/x86/kernel/cpu/perf_counter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c index 12cc05ed9f48..8f53f3a7da29 100644 --- a/arch/x86/kernel/cpu/perf_counter.c +++ b/arch/x86/kernel/cpu/perf_counter.c | |||
@@ -91,7 +91,7 @@ static u64 intel_pmu_raw_event(u64 event) | |||
91 | #define CORE_EVNTSEL_INV_MASK 0x00800000ULL | 91 | #define CORE_EVNTSEL_INV_MASK 0x00800000ULL |
92 | #define CORE_EVNTSEL_COUNTER_MASK 0xFF000000ULL | 92 | #define CORE_EVNTSEL_COUNTER_MASK 0xFF000000ULL |
93 | 93 | ||
94 | #define CORE_EVNTSEL_MASK \ | 94 | #define CORE_EVNTSEL_MASK \ |
95 | (CORE_EVNTSEL_EVENT_MASK | \ | 95 | (CORE_EVNTSEL_EVENT_MASK | \ |
96 | CORE_EVNTSEL_UNIT_MASK | \ | 96 | CORE_EVNTSEL_UNIT_MASK | \ |
97 | CORE_EVNTSEL_EDGE_MASK | \ | 97 | CORE_EVNTSEL_EDGE_MASK | \ |