diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-01-27 23:01:41 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-01-28 17:20:17 -0500 |
commit | f6f52baf2613dd319e9ba3f3319bf1f1c442e4b3 (patch) | |
tree | 1eb8f814939501c10f3f18af86f9c5a5d25c7310 /arch/x86/kernel/apic.c | |
parent | fe402e1f2b67a63f1e53ab2a316fc20f7ca4ec91 (diff) |
x86: clean up esr_disable() methods
Impact: cleanup
Most subarchitectures want to disable the APIC ESR (Error Status Register),
because they generally have hardware hacks that wrap standard CPUs into
a bigger system and hence the APIC bus is quite non-standard and weirdnesses
(lockups) have been seen with ESR reporting.
Remove the esr_disable macros and put the desired flag into each
subarchitecture's genapic template directly.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/apic.c')
-rw-r--r-- | arch/x86/kernel/apic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/x86/kernel/apic.c b/arch/x86/kernel/apic.c index b6740de18fbb..69d8c30d5711 100644 --- a/arch/x86/kernel/apic.c +++ b/arch/x86/kernel/apic.c | |||
@@ -1107,7 +1107,7 @@ static void __cpuinit lapic_setup_esr(void) | |||
1107 | return; | 1107 | return; |
1108 | } | 1108 | } |
1109 | 1109 | ||
1110 | if (esr_disable) { | 1110 | if (apic->ESR_DISABLE) { |
1111 | /* | 1111 | /* |
1112 | * Something untraceable is creating bad interrupts on | 1112 | * Something untraceable is creating bad interrupts on |
1113 | * secondary quads ... for the moment, just leave the | 1113 | * secondary quads ... for the moment, just leave the |
@@ -1157,7 +1157,7 @@ void __cpuinit setup_local_APIC(void) | |||
1157 | 1157 | ||
1158 | #ifdef CONFIG_X86_32 | 1158 | #ifdef CONFIG_X86_32 |
1159 | /* Pound the ESR really hard over the head with a big hammer - mbligh */ | 1159 | /* Pound the ESR really hard over the head with a big hammer - mbligh */ |
1160 | if (lapic_is_integrated() && esr_disable) { | 1160 | if (lapic_is_integrated() && apic->ESR_DISABLE) { |
1161 | apic_write(APIC_ESR, 0); | 1161 | apic_write(APIC_ESR, 0); |
1162 | apic_write(APIC_ESR, 0); | 1162 | apic_write(APIC_ESR, 0); |
1163 | apic_write(APIC_ESR, 0); | 1163 | apic_write(APIC_ESR, 0); |