diff options
author | Thomas Renninger <trenn@suse.de> | 2010-11-03 12:06:14 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2011-01-12 12:47:30 -0500 |
commit | d18960494f65ca4fa0d67c865aaca99452070d15 (patch) | |
tree | 93c37d0dd4bf8c254b312f75eb97f54077a9baed /arch/x86/include | |
parent | d8c216cfa57e8a579f41729cbb88c97835d9ac8d (diff) |
ACPI, intel_idle: Cleanup idle= internal variables
Having four variables for the same thing:
idle_halt, idle_nomwait, force_mwait and boot_option_idle_overrides
is rather confusing and unnecessary complex.
if idle= boot param is passed, only set up one variable:
boot_option_idle_overrides
Introduces following functional changes/fixes:
- intel_idle driver does not register if any idle=xy
boot param is passed.
- processor_idle.c will also not register a cpuidle driver
and get active if idle=halt is passed.
Before a cpuidle driver with one (C1, halt) state got registered
Now the default_idle function will be used which finally uses
the same idle call to enter sleep state (safe_halt()), but
without registering a whole cpuidle driver.
That means idle= param will always avoid cpuidle drivers to register
with one exception (same behavior as before):
idle=nomwait
may still register acpi_idle cpuidle driver, but C1 will not use
mwait, but hlt. This can be a workaround for IO based deeper sleep
states where C1 mwait causes problems.
Signed-off-by: Thomas Renninger <trenn@suse.de>
cc: x86@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'arch/x86/include')
-rw-r--r-- | arch/x86/include/asm/processor.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index cae9c3cb95cf..b79bd980461c 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h | |||
@@ -762,10 +762,11 @@ extern void select_idle_routine(const struct cpuinfo_x86 *c); | |||
762 | extern void init_c1e_mask(void); | 762 | extern void init_c1e_mask(void); |
763 | 763 | ||
764 | extern unsigned long boot_option_idle_override; | 764 | extern unsigned long boot_option_idle_override; |
765 | extern unsigned long idle_halt; | ||
766 | extern unsigned long idle_nomwait; | ||
767 | extern bool c1e_detected; | 765 | extern bool c1e_detected; |
768 | 766 | ||
767 | enum idle_boot_override {IDLE_NO_OVERRIDE=0, IDLE_HALT, IDLE_NOMWAIT, | ||
768 | IDLE_POLL, IDLE_FORCE_MWAIT}; | ||
769 | |||
769 | extern void enable_sep_cpu(void); | 770 | extern void enable_sep_cpu(void); |
770 | extern int sysenter_setup(void); | 771 | extern int sysenter_setup(void); |
771 | 772 | ||