diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2009-12-16 23:40:34 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-12-17 04:42:52 -0500 |
commit | 06d65bda75341485d32f33da474b0664819ad497 (patch) | |
tree | 3b5edc58b9c5a6a9b5cff4b5886f54929b12863a /arch/x86/include | |
parent | 61c1917f47f73c968e92d04d15370b1dc3ec4592 (diff) |
perf events, x86/stacktrace: Fix performance/softlockup by providing a special frame pointer-only stack walker
It's just wasteful for stacktrace users like perf to walk
through every entries on the stack whereas these only accept
reliable ones, ie: that the frame pointer validates.
Since perf requires pure reliable stacktraces, it needs a stack
walker based on frame pointers-only to optimize the stacktrace
processing.
This might solve some near-lockup scenarios that can be triggered
by call-graph tracing timer events.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1261024834-5336-2-git-send-regression-fweisbec@gmail.com>
[ v2: fix for modular builds and small detail tidyup ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/include')
-rw-r--r-- | arch/x86/include/asm/stacktrace.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h index 6c75151a3cca..35e89122a42f 100644 --- a/arch/x86/include/asm/stacktrace.h +++ b/arch/x86/include/asm/stacktrace.h | |||
@@ -22,6 +22,12 @@ print_context_stack(struct thread_info *tinfo, | |||
22 | const struct stacktrace_ops *ops, void *data, | 22 | const struct stacktrace_ops *ops, void *data, |
23 | unsigned long *end, int *graph); | 23 | unsigned long *end, int *graph); |
24 | 24 | ||
25 | extern unsigned long | ||
26 | print_context_stack_bp(struct thread_info *tinfo, | ||
27 | unsigned long *stack, unsigned long bp, | ||
28 | const struct stacktrace_ops *ops, void *data, | ||
29 | unsigned long *end, int *graph); | ||
30 | |||
25 | /* Generic stack tracer with callbacks */ | 31 | /* Generic stack tracer with callbacks */ |
26 | 32 | ||
27 | struct stacktrace_ops { | 33 | struct stacktrace_ops { |