diff options
author | Kirill A. Shutemov <kirill@shutemov.name> | 2014-12-10 18:44:36 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-12-10 20:41:08 -0500 |
commit | c164e038eee805147e95789dddb88ae3b3aca11c (patch) | |
tree | 6e3c5c99920142d46a9acb3d334e58c78d005467 /arch/x86/include/asm/pgtable.h | |
parent | 2314b42db67be30b747122d65c6cd2c85da34538 (diff) |
mm: fix huge zero page accounting in smaps report
As a small zero page, huge zero page should not be accounted in smaps
report as normal page.
For small pages we rely on vm_normal_page() to filter out zero page, but
vm_normal_page() is not designed to handle pmds. We only get here due
hackish cast pmd to pte in smaps_pte_range() -- pte and pmd format is not
necessary compatible on each and every architecture.
Let's add separate codepath to handle pmds. follow_trans_huge_pmd() will
detect huge zero page for us.
We would need pmd_dirty() helper to do this properly. The patch adds it
to THP-enabled architectures which don't yet have one.
[akpm@linux-foundation.org: use do_div to fix 32-bit build]
Signed-off-by: "Kirill A. Shutemov" <kirill@shutemov.name>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Fengwei Yin <yfw.kernel@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/x86/include/asm/pgtable.h')
-rw-r--r-- | arch/x86/include/asm/pgtable.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index aa97a070f09f..081d6f45e006 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h | |||
@@ -99,6 +99,11 @@ static inline int pte_young(pte_t pte) | |||
99 | return pte_flags(pte) & _PAGE_ACCESSED; | 99 | return pte_flags(pte) & _PAGE_ACCESSED; |
100 | } | 100 | } |
101 | 101 | ||
102 | static inline int pmd_dirty(pmd_t pmd) | ||
103 | { | ||
104 | return pmd_flags(pmd) & _PAGE_DIRTY; | ||
105 | } | ||
106 | |||
102 | static inline int pmd_young(pmd_t pmd) | 107 | static inline int pmd_young(pmd_t pmd) |
103 | { | 108 | { |
104 | return pmd_flags(pmd) & _PAGE_ACCESSED; | 109 | return pmd_flags(pmd) & _PAGE_ACCESSED; |