diff options
author | Andi Kleen <andi@firstfloor.org> | 2009-02-12 07:39:27 -0500 |
---|---|---|
committer | H. Peter Anvin <hpa@linux.intel.com> | 2009-02-17 18:32:38 -0500 |
commit | 123aa76ec0cab5d4881cd8509faed43231e68801 (patch) | |
tree | 9b15b722f93adf886fc4dcbacea062325b2ea365 /arch/x86/include/asm/mce.h | |
parent | 973a2dd1d50a11d380086601f14e59116f93e8c5 (diff) |
x86, mce: don't disable machine checks during code patching
Impact: low priority bug fix
This removes part of a a patch I added myself some time ago. After some
consideration the patch was a bad idea. In particular it stopped machine check
exceptions during code patching.
To quote the comment:
* MCEs only happen when something got corrupted and in this
* case we must do something about the corruption.
* Ignoring it is worse than a unlikely patching race.
* Also machine checks tend to be broadcast and if one CPU
* goes into machine check the others follow quickly, so we don't
* expect a machine check to cause undue problems during to code
* patching.
So undo the machine check related parts of
8f4e956b313dcccbc7be6f10808952345e3b638c NMIs are still disabled.
This only removes code, the only additions are a new comment.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch/x86/include/asm/mce.h')
-rw-r--r-- | arch/x86/include/asm/mce.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86/include/asm/mce.h b/arch/x86/include/asm/mce.h index 32c6e17b960b..5522273a3ad8 100644 --- a/arch/x86/include/asm/mce.h +++ b/arch/x86/include/asm/mce.h | |||
@@ -120,8 +120,6 @@ extern void mcheck_init(struct cpuinfo_x86 *c); | |||
120 | #else | 120 | #else |
121 | #define mcheck_init(c) do { } while (0) | 121 | #define mcheck_init(c) do { } while (0) |
122 | #endif | 122 | #endif |
123 | extern void stop_mce(void); | ||
124 | extern void restart_mce(void); | ||
125 | 123 | ||
126 | #endif /* __KERNEL__ */ | 124 | #endif /* __KERNEL__ */ |
127 | #endif /* _ASM_X86_MCE_H */ | 125 | #endif /* _ASM_X86_MCE_H */ |