diff options
author | Jeff Dike <jdike@addtoit.com> | 2006-10-02 05:17:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-02 10:57:14 -0400 |
commit | b68e31d0ebbcc909d1941f9f230c9d062a3a13d3 (patch) | |
tree | b32902e5de02081cbb9eca49d7bb0b444e2b4f23 /arch/v850/kernel | |
parent | ed97bd37efd8ff7398d3a7eedf4bcbf245f5dad3 (diff) |
[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of
structures in order to not have to document their locking. One of these
structures was a struct tty_operations. In order to const it in UML
without introducing compiler complaints, the declaration of
tty_set_operations needs to be changed, and then all of its callers need to
be fixed.
This patch declares all struct tty_operations in the tree as const. In all
cases, they are static and used only as input to tty_set_operations. As an
extra check, I ran an i386 allyesconfig build which produced no extra
warnings.
53 drivers are affected. I checked the history of a bunch of them, and in
most cases, there have been only a handful of maintenance changes in the
last six months. serial_core.c was the busiest one that I looked at.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/v850/kernel')
-rw-r--r-- | arch/v850/kernel/memcons.c | 2 | ||||
-rw-r--r-- | arch/v850/kernel/simcons.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/arch/v850/kernel/memcons.c b/arch/v850/kernel/memcons.c index 815f8a43926f..92f514fdcc79 100644 --- a/arch/v850/kernel/memcons.c +++ b/arch/v850/kernel/memcons.c | |||
@@ -104,7 +104,7 @@ int memcons_tty_chars_in_buffer (struct tty_struct *tty) | |||
104 | return 0; | 104 | return 0; |
105 | } | 105 | } |
106 | 106 | ||
107 | static struct tty_operations ops = { | 107 | static const struct tty_operations ops = { |
108 | .open = memcons_tty_open, | 108 | .open = memcons_tty_open, |
109 | .write = memcons_tty_write, | 109 | .write = memcons_tty_write, |
110 | .write_room = memcons_tty_write_room, | 110 | .write_room = memcons_tty_write_room, |
diff --git a/arch/v850/kernel/simcons.c b/arch/v850/kernel/simcons.c index 3975aa02cef8..9973596ae304 100644 --- a/arch/v850/kernel/simcons.c +++ b/arch/v850/kernel/simcons.c | |||
@@ -77,7 +77,7 @@ int simcons_tty_chars_in_buffer (struct tty_struct *tty) | |||
77 | return 0; | 77 | return 0; |
78 | } | 78 | } |
79 | 79 | ||
80 | static struct tty_operations ops = { | 80 | static const struct tty_operations ops = { |
81 | .open = simcons_tty_open, | 81 | .open = simcons_tty_open, |
82 | .write = simcons_tty_write, | 82 | .write = simcons_tty_write, |
83 | .write_room = simcons_tty_write_room, | 83 | .write_room = simcons_tty_write_room, |