diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-09 12:58:12 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-09 12:58:12 -0400 |
commit | 63b12bdb0d21aca527996fb2c547387bfd3e14b8 (patch) | |
tree | 6ab83b2a1c289f30fea18b88f04138ee69c37c6f /arch/um | |
parent | ad1f5caf34390bb20fdbb4eaf71b0494e89936f0 (diff) | |
parent | 059ade650ae57cfd371af690fdba887af04aded8 (diff) |
Merge branch 'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
Pull arch signal handling cleanup from Richard Weinberger:
"This patch series moves all remaining archs to the get_signal(),
signal_setup_done() and sigsp() functions.
Currently these archs use open coded variants of the said functions.
Further, unused parameters get removed from get_signal_to_deliver(),
tracehook_signal_handler() and signal_delivered().
At the end of the day we save around 500 lines of code."
* 'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc: (43 commits)
powerpc: Use sigsp()
openrisc: Use sigsp()
mn10300: Use sigsp()
mips: Use sigsp()
microblaze: Use sigsp()
metag: Use sigsp()
m68k: Use sigsp()
m32r: Use sigsp()
hexagon: Use sigsp()
frv: Use sigsp()
cris: Use sigsp()
c6x: Use sigsp()
blackfin: Use sigsp()
avr32: Use sigsp()
arm64: Use sigsp()
arc: Use sigsp()
sas_ss_flags: Remove nested ternary if
Rip out get_signal_to_deliver()
Clean up signal_delivered()
tracehook_signal_handler: Remove sig, info, ka and regs
...
Diffstat (limited to 'arch/um')
-rw-r--r-- | arch/um/include/shared/frame_kern.h | 12 | ||||
-rw-r--r-- | arch/um/kernel/signal.c | 27 |
2 files changed, 15 insertions, 24 deletions
diff --git a/arch/um/include/shared/frame_kern.h b/arch/um/include/shared/frame_kern.h index f2ca5702a4e2..a5cde5c433b4 100644 --- a/arch/um/include/shared/frame_kern.h +++ b/arch/um/include/shared/frame_kern.h | |||
@@ -6,14 +6,10 @@ | |||
6 | #ifndef __FRAME_KERN_H_ | 6 | #ifndef __FRAME_KERN_H_ |
7 | #define __FRAME_KERN_H_ | 7 | #define __FRAME_KERN_H_ |
8 | 8 | ||
9 | extern int setup_signal_stack_sc(unsigned long stack_top, int sig, | 9 | extern int setup_signal_stack_sc(unsigned long stack_top, struct ksignal *ksig, |
10 | struct k_sigaction *ka, | 10 | struct pt_regs *regs, sigset_t *mask); |
11 | struct pt_regs *regs, | 11 | extern int setup_signal_stack_si(unsigned long stack_top, struct ksignal *ksig, |
12 | sigset_t *mask); | 12 | struct pt_regs *regs, sigset_t *mask); |
13 | extern int setup_signal_stack_si(unsigned long stack_top, int sig, | ||
14 | struct k_sigaction *ka, | ||
15 | struct pt_regs *regs, struct siginfo *info, | ||
16 | sigset_t *mask); | ||
17 | 13 | ||
18 | #endif | 14 | #endif |
19 | 15 | ||
diff --git a/arch/um/kernel/signal.c b/arch/um/kernel/signal.c index f57e02e7910f..4f60e4aad790 100644 --- a/arch/um/kernel/signal.c +++ b/arch/um/kernel/signal.c | |||
@@ -18,8 +18,7 @@ EXPORT_SYMBOL(unblock_signals); | |||
18 | /* | 18 | /* |
19 | * OK, we're invoking a handler | 19 | * OK, we're invoking a handler |
20 | */ | 20 | */ |
21 | static void handle_signal(struct pt_regs *regs, unsigned long signr, | 21 | static void handle_signal(struct ksignal *ksig, struct pt_regs *regs) |
22 | struct k_sigaction *ka, struct siginfo *info) | ||
23 | { | 22 | { |
24 | sigset_t *oldset = sigmask_to_save(); | 23 | sigset_t *oldset = sigmask_to_save(); |
25 | int singlestep = 0; | 24 | int singlestep = 0; |
@@ -39,7 +38,7 @@ static void handle_signal(struct pt_regs *regs, unsigned long signr, | |||
39 | break; | 38 | break; |
40 | 39 | ||
41 | case -ERESTARTSYS: | 40 | case -ERESTARTSYS: |
42 | if (!(ka->sa.sa_flags & SA_RESTART)) { | 41 | if (!(ksig->ka.sa.sa_flags & SA_RESTART)) { |
43 | PT_REGS_SYSCALL_RET(regs) = -EINTR; | 42 | PT_REGS_SYSCALL_RET(regs) = -EINTR; |
44 | break; | 43 | break; |
45 | } | 44 | } |
@@ -52,32 +51,28 @@ static void handle_signal(struct pt_regs *regs, unsigned long signr, | |||
52 | } | 51 | } |
53 | 52 | ||
54 | sp = PT_REGS_SP(regs); | 53 | sp = PT_REGS_SP(regs); |
55 | if ((ka->sa.sa_flags & SA_ONSTACK) && (sas_ss_flags(sp) == 0)) | 54 | if ((ksig->ka.sa.sa_flags & SA_ONSTACK) && (sas_ss_flags(sp) == 0)) |
56 | sp = current->sas_ss_sp + current->sas_ss_size; | 55 | sp = current->sas_ss_sp + current->sas_ss_size; |
57 | 56 | ||
58 | #ifdef CONFIG_ARCH_HAS_SC_SIGNALS | 57 | #ifdef CONFIG_ARCH_HAS_SC_SIGNALS |
59 | if (!(ka->sa.sa_flags & SA_SIGINFO)) | 58 | if (!(ksig->ka.sa.sa_flags & SA_SIGINFO)) |
60 | err = setup_signal_stack_sc(sp, signr, ka, regs, oldset); | 59 | err = setup_signal_stack_sc(sp, ksig, regs, oldset); |
61 | else | 60 | else |
62 | #endif | 61 | #endif |
63 | err = setup_signal_stack_si(sp, signr, ka, regs, info, oldset); | 62 | err = setup_signal_stack_si(sp, ksig, regs, oldset); |
64 | 63 | ||
65 | if (err) | 64 | signal_setup_done(err, ksig, singlestep); |
66 | force_sigsegv(signr, current); | ||
67 | else | ||
68 | signal_delivered(signr, info, ka, regs, singlestep); | ||
69 | } | 65 | } |
70 | 66 | ||
71 | static int kern_do_signal(struct pt_regs *regs) | 67 | static int kern_do_signal(struct pt_regs *regs) |
72 | { | 68 | { |
73 | struct k_sigaction ka_copy; | 69 | struct ksignal ksig; |
74 | struct siginfo info; | 70 | int handled_sig = 0; |
75 | int sig, handled_sig = 0; | ||
76 | 71 | ||
77 | while ((sig = get_signal_to_deliver(&info, &ka_copy, regs, NULL)) > 0) { | 72 | while (get_signal(&ksig)) { |
78 | handled_sig = 1; | 73 | handled_sig = 1; |
79 | /* Whee! Actually deliver the signal. */ | 74 | /* Whee! Actually deliver the signal. */ |
80 | handle_signal(regs, sig, &ka_copy, &info); | 75 | handle_signal(&ksig, regs); |
81 | } | 76 | } |
82 | 77 | ||
83 | /* Did we come from a system call? */ | 78 | /* Did we come from a system call? */ |