diff options
author | Ulrich Drepper <drepper@redhat.com> | 2008-05-03 15:10:37 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-05-03 16:50:33 -0400 |
commit | d35c7b0e54a596c5a8134d75999b7f391a9c6550 (patch) | |
tree | 697bb89dbeccae28eb928b2589f500d747ed38ec /arch/um | |
parent | 2ddcca36c8bcfa251724fe342c8327451988be0d (diff) |
unified (weak) sys_pipe implementation
This replaces the duplicated arch-specific versions of "sys_pipe()" with
one unified implementation. This removes almost 250 lines of duplicated
code.
It's marked __weak, so that *if* an architecture wants to override the
default implementation it can do so by simply having its own replacement
version, since many architectures use alternate calling conventions for
the 'pipe()' system call for legacy reasons (ie traditional UNIX
implementations often return the two file descriptors in registers)
I still haven't changed the cris version even though Linus says the BKL
isn't needed. The arch maintainer can easily do it if there are really
no obstacles.
Signed-off-by: Ulrich Drepper <drepper@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/um')
-rw-r--r-- | arch/um/kernel/syscall.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/arch/um/kernel/syscall.c b/arch/um/kernel/syscall.c index 9cffc628a37e..128ee85bc8d9 100644 --- a/arch/um/kernel/syscall.c +++ b/arch/um/kernel/syscall.c | |||
@@ -73,23 +73,6 @@ long old_mmap(unsigned long addr, unsigned long len, | |||
73 | out: | 73 | out: |
74 | return err; | 74 | return err; |
75 | } | 75 | } |
76 | /* | ||
77 | * sys_pipe() is the normal C calling standard for creating | ||
78 | * a pipe. It's not the way unix traditionally does this, though. | ||
79 | */ | ||
80 | long sys_pipe(unsigned long __user * fildes) | ||
81 | { | ||
82 | int fd[2]; | ||
83 | long error; | ||
84 | |||
85 | error = do_pipe(fd); | ||
86 | if (!error) { | ||
87 | if (copy_to_user(fildes, fd, sizeof(fd))) | ||
88 | error = -EFAULT; | ||
89 | } | ||
90 | return error; | ||
91 | } | ||
92 | |||
93 | 76 | ||
94 | long sys_uname(struct old_utsname __user * name) | 77 | long sys_uname(struct old_utsname __user * name) |
95 | { | 78 | { |