[PATCH] uml: clean up after MADVISE_REMOVE

The MADVISE_REMOVE-checking code didn't clean up after itself.

Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

1 files changed, 12 insertions, 5 deletions

diff --git a/arch/um/os-Linux/process.c b/arch/um/os-Linux/process.c
index 3505f44f8a25..233be2f4f8cb 100644
--- a/arch/um/os-Linux/process.c
+++ b/arch/um/os-Linux/process.c
@@ -206,29 +206,36 @@ int os_drop_memory(void *addr, int length)
 int can_drop_memory(void)
 {
         void *addr;
-        int fd;
+        int fd, ok = 0;
 
         printk("Checking host MADV_REMOVE support...");
         fd = create_mem_file(UM_KERN_PAGE_SIZE);
         if(fd < 0){
                 printk("Creating test memory file failed, err = %d\n", -fd);
-                return 0;
+                goto out;
         }
 
         addr = mmap64(NULL, UM_KERN_PAGE_SIZE, PROT_READ | PROT_WRITE,
                       MAP_SHARED, fd, 0);
         if(addr == MAP_FAILED){
                 printk("Mapping test memory file failed, err = %d\n", -errno);
-                return 0;
+                goto out_close;
         }
 
         if(madvise(addr, UM_KERN_PAGE_SIZE, MADV_REMOVE) != 0){
                 printk("MADV_REMOVE failed, err = %d\n", -errno);
-                return 0;
+                goto out_unmap;
         }
 
         printk("OK\n");
-        return 1;
+        ok = 1;
+
+out_unmap:
+        munmap(addr, UM_KERN_PAGE_SIZE);
+out_close:
+        close(fd);
+out:
+        return ok;
 }
 
 void init_new_thread_stack(void *sig_stack, void (*usr1_handler)(int))