uml: style fixes pass 1

Formatting changes in the files which have been changed in the
tt-removal patchset so far.  These include:
	copyright updates
	header file trimming
	style fixes
	adding severity to printks
	indenting Kconfig help according to the predominant kernel style

These changes should be entirely non-functional.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

4 files changed, 71 insertions, 81 deletions

diff --git a/arch/um/kernel/Makefile b/arch/um/kernel/Makefile
index 6651937a2d26..499e5e95e609 100644
--- a/arch/um/kernel/Makefile
+++ b/arch/um/kernel/Makefile
@@ -1,5 +1,5 @@
 #
-# Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
+# Copyright (C) 2002 - 2007 Jeff Dike (jdike@{addtoit,linux,intel}.com)
 # Licensed under the GPL
 #
 
diff --git a/arch/um/kernel/init_task.c b/arch/um/kernel/init_task.c
index 33055082356e..dcfceca95052 100644
--- a/arch/um/kernel/init_task.c
+++ b/arch/um/kernel/init_task.c
@@ -3,16 +3,12 @@
  * Licensed under the GPL
  */
 
-#include "linux/mm.h"
-#include "linux/fs.h"
-#include "linux/module.h"
 #include "linux/sched.h"
 #include "linux/init_task.h"
+#include "linux/fs.h"
+#include "linux/module.h"
 #include "linux/mqueue.h"
 #include "asm/uaccess.h"
-#include "asm/pgtable.h"
-#include "mem_user.h"
-#include "os.h"
 
 static struct fs_struct init_fs = INIT_FS;
 struct mm_struct init_mm = INIT_MM(init_mm);
diff --git a/arch/um/kernel/smp.c b/arch/um/kernel/smp.c
index 15bb54365779..36d89cf8d20b 100644
--- a/arch/um/kernel/smp.c
+++ b/arch/um/kernel/smp.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2000 - 2003 Jeff Dike (jdike@addtoit.com)
+ * Copyright (C) 2000 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
  * Licensed under the GPL
  */
 
@@ -56,12 +56,12 @@ void smp_send_stop(void)
         int i;
 
         printk(KERN_INFO "Stopping all CPUs...");
-        for(i = 0; i < num_online_cpus(); i++){
-                if(i == current_thread->cpu)
+        for (i = 0; i < num_online_cpus(); i++) {
+                if (i == current_thread->cpu)
                         continue;
                 os_write_file(cpu_data[i].ipi_pipe[1], "S", 1);
         }
-        printk("done\n");
+        printk(KERN_INFO "done\n");
 }
 
 static cpumask_t smp_commenced_mask = CPU_MASK_NONE;
@@ -72,7 +72,7 @@ static int idle_proc(void *cpup)
         int cpu = (int) cpup, err;
 
         err = os_pipe(cpu_data[cpu].ipi_pipe, 1, 1);
-        if(err < 0)
+        if (err < 0)
                 panic("CPU#%d failed to create IPI pipe, err = %d", cpu, -err);
 
         os_set_fd_async(cpu_data[cpu].ipi_pipe[0],
@@ -80,7 +80,7 @@ static int idle_proc(void *cpup)
 
         wmb();
         if (cpu_test_and_set(cpu, cpu_callin_map)) {
-                printk("huh, CPU#%d already present??\n", cpu);
+                printk(KERN_ERR "huh, CPU#%d already present??\n", cpu);
                 BUG();
         }
 
@@ -99,7 +99,7 @@ static struct task_struct *idle_thread(int cpu)
         current->thread.request.u.thread.proc = idle_proc;
         current->thread.request.u.thread.arg = (void *) cpu;
         new_task = fork_idle(cpu);
-        if(IS_ERR(new_task))
+        if (IS_ERR(new_task))
                 panic("copy_process failed in idle_thread, error = %ld",
                       PTR_ERR(new_task));
 
@@ -126,14 +126,14 @@ void smp_prepare_cpus(unsigned int maxcpus)
         cpu_set(me, cpu_callin_map);
 
         err = os_pipe(cpu_data[me].ipi_pipe, 1, 1);
-        if(err < 0)
+        if (err < 0)
                 panic("CPU#0 failed to create IPI pipe, errno = %d", -err);
 
         os_set_fd_async(cpu_data[me].ipi_pipe[0],
                      current->thread.mode.tt.extern_pid);
 
-        for(cpu = 1; cpu < ncpus; cpu++){
-                printk("Booting processor %d...\n", cpu);
+        for (cpu = 1; cpu < ncpus; cpu++) {
+                printk(KERN_INFO "Booting processor %d...\n", cpu);
 
                 idle = idle_thread(cpu);
 
@@ -144,8 +144,8 @@ void smp_prepare_cpus(unsigned int maxcpus)
                         cpu_relax();
 
                 if (cpu_isset(cpu, cpu_callin_map))
-                        printk("done\n");
-                else printk("failed\n");
+                        printk(KERN_INFO "done\n");
+                else printk(KERN_INFO "failed\n");
         }
 }
 
@@ -187,13 +187,14 @@ void IPI_handler(int cpu)
                         break;
 
                 case 'S':
-                        printk("CPU#%d stopping\n", cpu);
-                        while(1)
+                        printk(KERN_INFO "CPU#%d stopping\n", cpu);
+                        while (1)
                                 pause();
                         break;
 
                 default:
-                        printk("CPU#%d received unknown IPI [%c]!\n", cpu, c);
+                        printk(KERN_ERR "CPU#%d received unknown IPI [%c]!\n",
+                               cpu, c);
                         break;
                 }
         }
diff --git a/arch/um/kernel/trap.c b/arch/um/kernel/trap.c
index c517c449d0dd..4b472ca53485 100644
--- a/arch/um/kernel/trap.c
+++ b/arch/um/kernel/trap.c
@@ -1,38 +1,24 @@
 /*
- * Copyright (C) 2000, 2001 Jeff Dike (jdike@karaya.com)
+ * Copyright (C) 2000 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
  * Licensed under the GPL
  */
 
-#include "linux/kernel.h"
-#include "asm/errno.h"
-#include "linux/sched.h"
-#include "linux/mm.h"
-#include "linux/spinlock.h"
-#include "linux/init.h"
-#include "linux/ptrace.h"
-#include "asm/semaphore.h"
-#include "asm/pgtable.h"
-#include "asm/pgalloc.h"
-#include "asm/tlbflush.h"
-#include "asm/a.out.h"
-#include "asm/current.h"
-#include "asm/irq.h"
-#include "sysdep/sigcontext.h"
-#include "kern_util.h"
-#include "as-layout.h"
+#include <linux/mm.h>
+#include <linux/sched.h>
+#include <linux/hardirq.h>
+#include <asm/current.h>
+#include <asm/pgtable.h>
+#include <asm/tlbflush.h>
 #include "arch.h"
-#include "kern.h"
-#include "chan_kern.h"
-#include "mconsole_kern.h"
-#include "mem.h"
-#include "mem_kern.h"
-#include "sysdep/sigcontext.h"
-#include "sysdep/ptrace.h"
-#include "os.h"
-#include "skas.h"
+#include "as-layout.h"
+#include "kern_util.h"
 #include "os.h"
+#include "sysdep/sigcontext.h"
 
-/* Note this is constrained to return 0, -EFAULT, -EACCESS, -ENOMEM by segv(). */
+/*
+ * Note this is constrained to return 0, -EFAULT, -EACCESS, -ENOMEM by
+ * segv().
+ */
 int handle_page_fault(unsigned long address, unsigned long ip,
                       int is_write, int is_user, int *code_out)
 {
@@ -46,31 +32,33 @@ int handle_page_fault(unsigned long address, unsigned long ip,
 
         *code_out = SEGV_MAPERR;
 
-        /* If the fault was during atomic operation, don't take the fault, just
-         * fail. */
+        /*
+         * If the fault was during atomic operation, don't take the fault, just
+         * fail.
+         */
         if (in_atomic())
                 goto out_nosemaphore;
 
         down_read(&mm->mmap_sem);
         vma = find_vma(mm, address);
-        if(!vma)
+        if (!vma)
                 goto out;
-        else if(vma->vm_start <= address)
+        else if (vma->vm_start <= address)
                 goto good_area;
-        else if(!(vma->vm_flags & VM_GROWSDOWN))
+        else if (!(vma->vm_flags & VM_GROWSDOWN))
                 goto out;
-        else if(is_user && !ARCH_IS_STACKGROW(address))
+        else if (is_user && !ARCH_IS_STACKGROW(address))
                 goto out;
-        else if(expand_stack(vma, address))
+        else if (expand_stack(vma, address))
                 goto out;
 
 good_area:
         *code_out = SEGV_ACCERR;
-        if(is_write && !(vma->vm_flags & VM_WRITE))
+        if (is_write && !(vma->vm_flags & VM_WRITE))
                 goto out;
 
         /* Don't require VM_READ|VM_EXEC for write faults! */
-        if(!is_write && !(vma->vm_flags & (VM_READ | VM_EXEC)))
+        if (!is_write && !(vma->vm_flags & (VM_READ | VM_EXEC)))
                 goto out;
 
         do {
@@ -96,9 +84,10 @@ survive:
                 pud = pud_offset(pgd, address);
                 pmd = pmd_offset(pud, address);
                 pte = pte_offset_kernel(pmd, address);
-        } while(!pte_present(*pte));
+        } while (!pte_present(*pte));
         err = 0;
-        /* The below warning was added in place of
+        /*
+         * The below warning was added in place of
          *      pte_mkyoung(); if (is_write) pte_mkdirty();
          * If it's triggered, we'd see normally a hang here (a clean pte is
          * marked read-only to emulate the dirty bit).
@@ -112,7 +101,7 @@ survive:
 out:
         up_read(&mm->mmap_sem);
 out_nosemaphore:
-        return(err);
+        return err;
 
 /*
  * We ran out of memory, or some other thing happened to us that made
@@ -143,7 +132,7 @@ static void segv_handler(int sig, union uml_pt_regs *regs)
 {
         struct faultinfo * fi = UPT_FAULTINFO(regs);
 
-        if(UPT_IS_USER(regs) && !SEGV_IS_FIXABLE(fi)){
+        if (UPT_IS_USER(regs) && !SEGV_IS_FIXABLE(fi)) {
                 bad_segv(*fi, UPT_IP(regs));
                 return;
         }
@@ -165,37 +154,41 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,
         int is_write = FAULT_WRITE(fi);
         unsigned long address = FAULT_ADDRESS(fi);
 
-        if(!is_user && (address >= start_vm) && (address < end_vm)){
+        if (!is_user && (address >= start_vm) && (address < end_vm)) {
                 flush_tlb_kernel_vm();
                 return 0;
         }
-        else if(current->mm == NULL) {
+        else if (current->mm == NULL) {
                 show_regs(container_of(regs, struct pt_regs, regs));
-                panic("Segfault with no mm");
+                panic("Segfault with no mm");
         }
 
         if (SEGV_IS_FIXABLE(&fi) || SEGV_MAYBE_FIXABLE(&fi))
-                err = handle_page_fault(address, ip, is_write, is_user, &si.si_code);
+                err = handle_page_fault(address, ip, is_write, is_user,
+                                        &si.si_code);
         else {
                 err = -EFAULT;
-                /* A thread accessed NULL, we get a fault, but CR2 is invalid.
-                 * This code is used in __do_copy_from_user() of TT mode. */
+                /*
+                 * A thread accessed NULL, we get a fault, but CR2 is invalid.
+                 * This code is used in __do_copy_from_user() of TT mode.
+                 * XXX tt mode is gone, so maybe this isn't needed any more
+                 */
                 address = 0;
         }
 
         catcher = current->thread.fault_catcher;
-        if(!err)
+        if (!err)
                 return 0;
-        else if(catcher != NULL){
+        else if (catcher != NULL) {
                 current->thread.fault_addr = (void *) address;
                 do_longjmp(catcher, 1);
         }
-        else if(current->thread.fault_addr != NULL)
+        else if (current->thread.fault_addr != NULL)
                 panic("fault_addr set but no fault catcher");
-        else if(!is_user && arch_fixup(ip, regs))
+        else if (!is_user && arch_fixup(ip, regs))
                 return 0;
 
-        if(!is_user) {
+        if (!is_user) {
                 show_regs(container_of(regs, struct pt_regs, regs));
                 panic("Kernel mode fault at addr 0x%lx, ip 0x%lx",
                       address, ip);
@@ -209,7 +202,7 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,
                 current->thread.arch.faultinfo = fi;
                 force_sig_info(SIGBUS, &si, current);
         } else if (err == -ENOMEM) {
-                printk("VM: killing process %s\n", current->comm);
+                printk(KERN_INFO "VM: killing process %s\n", current->comm);
                 do_exit(SIGKILL);
         } else {
                 BUG_ON(err != -EFAULT);
@@ -223,13 +216,13 @@ unsigned long segv(struct faultinfo fi, unsigned long ip, int is_user,
 
 void relay_signal(int sig, union uml_pt_regs *regs)
 {
-        if(arch_handle_signal(sig, regs))
+        if (arch_handle_signal(sig, regs))
                 return;
 
-        if(!UPT_IS_USER(regs)){
-                if(sig == SIGBUS)
-                        printk("Bus error - the host /dev/shm or /tmp mount "
-                               "likely just ran out of space\n");
+        if (!UPT_IS_USER(regs)) {
+                if (sig == SIGBUS)
+                        printk(KERN_ERR "Bus error - the host /dev/shm or /tmp "
+                               "mount likely just ran out of space\n");
                 panic("Kernel mode signal %d", sig);
         }
 
@@ -239,7 +232,7 @@ void relay_signal(int sig, union uml_pt_regs *regs)
 
 static void bus_handler(int sig, union uml_pt_regs *regs)
 {
-        if(current->thread.fault_catcher != NULL)
+        if (current->thread.fault_catcher != NULL)
                 do_longjmp(current->thread.fault_catcher, 1);
         else relay_signal(sig, regs);
 }