[PATCH] uml: system call path cleanup

This merges two sets of files which had no business being split apart in the
first place.

Signed-off-by: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

4 files changed, 51 insertions, 88 deletions

diff --git a/arch/um/kernel/skas/Makefile b/arch/um/kernel/skas/Makefile
index d296d55ade4b..db36c7c95940 100644
--- a/arch/um/kernel/skas/Makefile
+++ b/arch/um/kernel/skas/Makefile
@@ -4,7 +4,7 @@
 #
 
 obj-y := clone.o exec_kern.o mem.o mem_user.o mmu.o process.o process_kern.o \
-        syscall_kern.o syscall_user.o tlb.o trap_user.o uaccess.o \
+        syscall.o tlb.o trap_user.o uaccess.o
 
 subdir- := util
 
diff --git a/arch/um/kernel/skas/syscall.c b/arch/um/kernel/skas/syscall.c
new file mode 100644
index 000000000000..51fb94076fcf
--- /dev/null
+++ b/arch/um/kernel/skas/syscall.c
@@ -0,0 +1,50 @@
+/*
+ * Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
+ * Licensed under the GPL
+ */
+
+#include "linux/sys.h"
+#include "linux/ptrace.h"
+#include "asm/errno.h"
+#include "asm/unistd.h"
+#include "asm/ptrace.h"
+#include "asm/current.h"
+#include "sysdep/syscalls.h"
+#include "kern_util.h"
+#include "syscall.h"
+
+void handle_syscall(union uml_pt_regs *r)
+{
+        struct pt_regs *regs = container_of(r, struct pt_regs, regs);
+        long result;
+        int syscall;
+#ifdef UML_CONFIG_SYSCALL_DEBUG
+        int index;
+
+        index = record_syscall_start(UPT_SYSCALL_NR(r));
+#endif
+        syscall_trace(r, 0);
+
+        current->thread.nsyscalls++;
+        nsyscalls++;
+
+        /* This should go in the declaration of syscall, but when I do that,
+         * strace -f -c bash -c 'ls ; ls' breaks, sometimes not tracing
+         * children at all, sometimes hanging when bash doesn't see the first
+         * ls exit.
+         * The assembly looks functionally the same to me.  This is
+         *     gcc version 4.0.1 20050727 (Red Hat 4.0.1-5)
+         * in case it's a compiler bug.
+         */
+        syscall = UPT_SYSCALL_NR(r);
+        if((syscall >= NR_syscalls) || (syscall < 0))
+                result = -ENOSYS;
+        else result = EXECUTE_SYSCALL(syscall, regs);
+
+        REGS_SET_SYSCALL_RETURN(r->skas.regs, result);
+
+        syscall_trace(r, 1);
+#ifdef UML_CONFIG_SYSCALL_DEBUG
+        record_syscall_end(index, result);
+#endif
+}
diff --git a/arch/um/kernel/skas/syscall_kern.c b/arch/um/kernel/skas/syscall_kern.c
deleted file mode 100644
index bdf040ce5b8e..000000000000
--- a/arch/um/kernel/skas/syscall_kern.c
+++ /dev/null
@@ -1,43 +0,0 @@
-/* 
- * Copyright (C) 2002 - 2003 Jeff Dike (jdike@addtoit.com)
- * Licensed under the GPL
- */
-
-#include "linux/sys.h"
-#include "linux/ptrace.h"
-#include "asm/errno.h"
-#include "asm/unistd.h"
-#include "asm/ptrace.h"
-#include "asm/current.h"
-#include "sysdep/syscalls.h"
-#include "kern_util.h"
-
-extern syscall_handler_t *sys_call_table[];
-
-long execute_syscall_skas(void *r)
-{
-        struct pt_regs *regs = r;
-        long res;
-        int syscall;
-
-        current->thread.nsyscalls++;
-        nsyscalls++;
-        syscall = UPT_SYSCALL_NR(&regs->regs);
-
-        if((syscall >= NR_syscalls) || (syscall < 0))
-                res = -ENOSYS;
-        else res = EXECUTE_SYSCALL(syscall, regs);
-
-        return(res);
-}
-
-/*
- * Overrides for Emacs so that we follow Linus's tabbing style.
- * Emacs will notice this stuff at the end of the file and automatically
- * adjust the settings for this buffer only.  This must remain at the end
- * of the file.
- * ---------------------------------------------------------------------------
- * Local variables:
- * c-file-style: "linux"
- * End:
- */
diff --git a/arch/um/kernel/skas/syscall_user.c b/arch/um/kernel/skas/syscall_user.c
deleted file mode 100644
index 6b0664970147..000000000000
--- a/arch/um/kernel/skas/syscall_user.c
+++ /dev/null
@@ -1,44 +0,0 @@
-/* 
- * Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
- * Licensed under the GPL
- */
-
-#include <stdlib.h>
-#include <signal.h>
-#include "kern_util.h"
-#include "uml-config.h"
-#include "syscall_user.h"
-#include "sysdep/ptrace.h"
-#include "sysdep/sigcontext.h"
-#include "skas.h"
-
-void handle_syscall(union uml_pt_regs *regs)
-{
-        long result;
-#ifdef UML_CONFIG_SYSCALL_DEBUG
-        int index;
-
-        index = record_syscall_start(UPT_SYSCALL_NR(regs));
-#endif
-
-        syscall_trace(regs, 0);
-        result = execute_syscall_skas(regs);
-
-        REGS_SET_SYSCALL_RETURN(regs->skas.regs, result);
-
-        syscall_trace(regs, 1);
-#ifdef UML_CONFIG_SYSCALL_DEBUG
-        record_syscall_end(index, result);
-#endif
-}
-
-/*
- * Overrides for Emacs so that we follow Linus's tabbing style.
- * Emacs will notice this stuff at the end of the file and automatically
- * adjust the settings for this buffer only.  This must remain at the end
- * of the file.
- * ---------------------------------------------------------------------------
- * Local variables:
- * c-file-style: "linux"
- * End:
- */