diff options
author | Jeff Dike <jdike@addtoit.com> | 2008-02-05 01:30:52 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-05 12:44:28 -0500 |
commit | 9157f90f08f7db3188cd06971f41cb2ba5646e57 (patch) | |
tree | f8a546798ec49d973117b012973b1af38014bd2b /arch/um/kernel/skas | |
parent | b8bec829c90d45a2d115a52f3a928ce841afc3d4 (diff) |
uml: move um_virt_to_phys
This patchset makes UML build and run with three-level page tables on
32-bit hosts. This is an uncommon use case, but the code here needed
fixing and cleaning up, so 32-bit three-level pages tables were tested
to make sure the changes are good.
Patch 1 - code movement
Patch 2 - header untangling
Patch 3 - style fixups in files affected so far
Patch 4 - clean up use of current.h
Patch 5 - fix sizes of types that are different between 2 and 3-level
page tables - three-level page table support should build at
this point
Patch 6 - tidy (i.e. eliminate much of) the code that figures out how
big the address space is
Patch 7 - change um_virt_to_phys into virt_to_pte, clean its
interface, and clean its (so far) one caller
Patch 8 - the stub pages are covered with a VMA, allowing some nasty
code to be thrown out - three-level page tables now work
This patch:
um_virt_to_phys only has one user, so it can be moved to the same file
and made static. Its declarations in pgtable.h and ksyms.c are also
gone.
current_cmd was another apparent user, but it itself isn't used, so it
is deleted.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/um/kernel/skas')
-rw-r--r-- | arch/um/kernel/skas/uaccess.c | 34 |
1 files changed, 32 insertions, 2 deletions
diff --git a/arch/um/kernel/skas/uaccess.c b/arch/um/kernel/skas/uaccess.c index 1d8b119f2d0e..302425b03d49 100644 --- a/arch/um/kernel/skas/uaccess.c +++ b/arch/um/kernel/skas/uaccess.c | |||
@@ -12,8 +12,38 @@ | |||
12 | #include "kern_util.h" | 12 | #include "kern_util.h" |
13 | #include "os.h" | 13 | #include "os.h" |
14 | 14 | ||
15 | extern void *um_virt_to_phys(struct task_struct *task, unsigned long addr, | 15 | static void *um_virt_to_phys(struct task_struct *task, unsigned long addr, |
16 | pte_t *pte_out); | 16 | pte_t *pte_out) |
17 | { | ||
18 | pgd_t *pgd; | ||
19 | pud_t *pud; | ||
20 | pmd_t *pmd; | ||
21 | pte_t *pte; | ||
22 | pte_t ptent; | ||
23 | |||
24 | if (task->mm == NULL) | ||
25 | return ERR_PTR(-EINVAL); | ||
26 | pgd = pgd_offset(task->mm, addr); | ||
27 | if (!pgd_present(*pgd)) | ||
28 | return ERR_PTR(-EINVAL); | ||
29 | |||
30 | pud = pud_offset(pgd, addr); | ||
31 | if (!pud_present(*pud)) | ||
32 | return ERR_PTR(-EINVAL); | ||
33 | |||
34 | pmd = pmd_offset(pud, addr); | ||
35 | if (!pmd_present(*pmd)) | ||
36 | return ERR_PTR(-EINVAL); | ||
37 | |||
38 | pte = pte_offset_kernel(pmd, addr); | ||
39 | ptent = *pte; | ||
40 | if (!pte_present(ptent)) | ||
41 | return ERR_PTR(-EINVAL); | ||
42 | |||
43 | if (pte_out != NULL) | ||
44 | *pte_out = ptent; | ||
45 | return (void *) (pte_val(ptent) & PAGE_MASK) + (addr & ~PAGE_MASK); | ||
46 | } | ||
17 | 47 | ||
18 | static unsigned long maybe_map(unsigned long virt, int is_write) | 48 | static unsigned long maybe_map(unsigned long virt, int is_write) |
19 | { | 49 | { |