diff options
author | Jeff Dike <jdike@addtoit.com> | 2007-10-16 04:27:31 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-16 12:43:08 -0400 |
commit | b53f35a8093e6aed7e8e880eaa0b89a3d2fdfb0a (patch) | |
tree | 50e19688753650e27b1f7fc1d48eb8683666e6b7 /arch/um/include | |
parent | cd1ae0e49bdd814cfaa2e5ab28cff21a30e20085 (diff) |
uml: network driver MTU cleanups
A bunch of MTU-related cleanups in the network code.
First, there is the addition of the notion of a maximally-sized packet, which
is the MTU plus headers. This is used to size the skb that will receive a
packet. This allows ether_adjust_skb to go away, as it was used to resize the
skb after it was allocated.
Since the skb passed into the low-level read routine is no longer resized, and
possibly reallocated, there, they (and the write routines) don't need to get
an sk_buff **. They just need the sk_buff * now. The callers of
ether_adjust_skb still need to do the skb_put, so that's now inlined.
The MAX_PACKET definitions in most of the drivers are gone.
The set_mtu methods were all the same and did nothing, so they can be
removed.
The ethertap driver had a typo which doubled the size of the packet rather
than adding two bytes to it. It also wasn't defining its setup_size, causing
a zero-byte kmalloc and crash when the invalid pointer returned from kmalloc
was dereferenced.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/um/include')
-rw-r--r-- | arch/um/include/net_kern.h | 13 | ||||
-rw-r--r-- | arch/um/include/net_user.h | 4 |
2 files changed, 8 insertions, 9 deletions
diff --git a/arch/um/include/net_kern.h b/arch/um/include/net_kern.h index 9237056b9103..d843c7924a7c 100644 --- a/arch/um/include/net_kern.h +++ b/arch/um/include/net_kern.h | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) 2002 Jeff Dike (jdike@karaya.com) | 2 | * Copyright (C) 2002 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) |
3 | * Licensed under the GPL | 3 | * Licensed under the GPL |
4 | */ | 4 | */ |
5 | 5 | ||
@@ -30,24 +30,24 @@ struct uml_net_private { | |||
30 | struct work_struct work; | 30 | struct work_struct work; |
31 | int fd; | 31 | int fd; |
32 | unsigned char mac[ETH_ALEN]; | 32 | unsigned char mac[ETH_ALEN]; |
33 | int max_packet; | ||
33 | unsigned short (*protocol)(struct sk_buff *); | 34 | unsigned short (*protocol)(struct sk_buff *); |
34 | int (*open)(void *); | 35 | int (*open)(void *); |
35 | void (*close)(int, void *); | 36 | void (*close)(int, void *); |
36 | void (*remove)(void *); | 37 | void (*remove)(void *); |
37 | int (*read)(int, struct sk_buff **skb, struct uml_net_private *); | 38 | int (*read)(int, struct sk_buff *skb, struct uml_net_private *); |
38 | int (*write)(int, struct sk_buff **skb, struct uml_net_private *); | 39 | int (*write)(int, struct sk_buff *skb, struct uml_net_private *); |
39 | 40 | ||
40 | void (*add_address)(unsigned char *, unsigned char *, void *); | 41 | void (*add_address)(unsigned char *, unsigned char *, void *); |
41 | void (*delete_address)(unsigned char *, unsigned char *, void *); | 42 | void (*delete_address)(unsigned char *, unsigned char *, void *); |
42 | int (*set_mtu)(int mtu, void *); | ||
43 | char user[0]; | 43 | char user[0]; |
44 | }; | 44 | }; |
45 | 45 | ||
46 | struct net_kern_info { | 46 | struct net_kern_info { |
47 | void (*init)(struct net_device *, void *); | 47 | void (*init)(struct net_device *, void *); |
48 | unsigned short (*protocol)(struct sk_buff *); | 48 | unsigned short (*protocol)(struct sk_buff *); |
49 | int (*read)(int, struct sk_buff **skb, struct uml_net_private *); | 49 | int (*read)(int, struct sk_buff *skb, struct uml_net_private *); |
50 | int (*write)(int, struct sk_buff **skb, struct uml_net_private *); | 50 | int (*write)(int, struct sk_buff *skb, struct uml_net_private *); |
51 | }; | 51 | }; |
52 | 52 | ||
53 | struct transport { | 53 | struct transport { |
@@ -62,7 +62,6 @@ struct transport { | |||
62 | 62 | ||
63 | extern struct net_device *ether_init(int); | 63 | extern struct net_device *ether_init(int); |
64 | extern unsigned short ether_protocol(struct sk_buff *); | 64 | extern unsigned short ether_protocol(struct sk_buff *); |
65 | extern struct sk_buff *ether_adjust_skb(struct sk_buff *skb, int extra); | ||
66 | extern int tap_setup_common(char *str, char *type, char **dev_name, | 65 | extern int tap_setup_common(char *str, char *type, char **dev_name, |
67 | char **mac_out, char **gate_addr); | 66 | char **mac_out, char **gate_addr); |
68 | extern void register_transport(struct transport *new); | 67 | extern void register_transport(struct transport *new); |
diff --git a/arch/um/include/net_user.h b/arch/um/include/net_user.h index cfe7c50634b9..63bee158cd8e 100644 --- a/arch/um/include/net_user.h +++ b/arch/um/include/net_user.h | |||
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | * Copyright (C) 2002 Jeff Dike (jdike@karaya.com) | 2 | * Copyright (C) 2002 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) |
3 | * Licensed under the GPL | 3 | * Licensed under the GPL |
4 | */ | 4 | */ |
5 | 5 | ||
@@ -18,10 +18,10 @@ struct net_user_info { | |||
18 | int (*open)(void *); | 18 | int (*open)(void *); |
19 | void (*close)(int, void *); | 19 | void (*close)(int, void *); |
20 | void (*remove)(void *); | 20 | void (*remove)(void *); |
21 | int (*set_mtu)(int mtu, void *); | ||
22 | void (*add_address)(unsigned char *, unsigned char *, void *); | 21 | void (*add_address)(unsigned char *, unsigned char *, void *); |
23 | void (*delete_address)(unsigned char *, unsigned char *, void *); | 22 | void (*delete_address)(unsigned char *, unsigned char *, void *); |
24 | int max_packet; | 23 | int max_packet; |
24 | int mtu; | ||
25 | }; | 25 | }; |
26 | 26 | ||
27 | extern void ether_user_init(void *data, void *dev); | 27 | extern void ether_user_init(void *data, void *dev); |