diff options
author | Jeff Dike <jdike@addtoit.com> | 2006-10-02 05:17:18 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-02 10:57:14 -0400 |
commit | b68e31d0ebbcc909d1941f9f230c9d062a3a13d3 (patch) | |
tree | b32902e5de02081cbb9eca49d7bb0b444e2b4f23 /arch/um/include/line.h | |
parent | ed97bd37efd8ff7398d3a7eedf4bcbf245f5dad3 (diff) |
[PATCH] const struct tty_operations
As part of an SMP cleanliness pass over UML, I consted a bunch of
structures in order to not have to document their locking. One of these
structures was a struct tty_operations. In order to const it in UML
without introducing compiler complaints, the declaration of
tty_set_operations needs to be changed, and then all of its callers need to
be fixed.
This patch declares all struct tty_operations in the tree as const. In all
cases, they are static and used only as input to tty_set_operations. As an
extra check, I ran an i386 allyesconfig build which produced no extra
warnings.
53 drivers are affected. I checked the history of a bunch of them, and in
most cases, there have been only a handful of maintenance changes in the
last six months. serial_core.c was the busiest one that I looked at.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'arch/um/include/line.h')
-rw-r--r-- | arch/um/include/line.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/arch/um/include/line.h b/arch/um/include/line.h index 642c9a0320f9..7be24811bb30 100644 --- a/arch/um/include/line.h +++ b/arch/um/include/line.h | |||
@@ -91,10 +91,9 @@ extern int line_setup_irq(int fd, int input, int output, struct line *line, | |||
91 | void *data); | 91 | void *data); |
92 | extern void line_close_chan(struct line *line); | 92 | extern void line_close_chan(struct line *line); |
93 | extern struct tty_driver * line_register_devfs(struct lines *set, | 93 | extern struct tty_driver * line_register_devfs(struct lines *set, |
94 | struct line_driver *line_driver, | 94 | struct line_driver *line_driver, |
95 | struct tty_operations *driver, | 95 | const struct tty_operations *driver, |
96 | struct line *lines, | 96 | struct line *lines, int nlines); |
97 | int nlines); | ||
98 | extern void lines_init(struct line *lines, int nlines, struct chan_opts *opts); | 97 | extern void lines_init(struct line *lines, int nlines, struct chan_opts *opts); |
99 | extern void close_lines(struct line *lines, int nlines); | 98 | extern void close_lines(struct line *lines, int nlines); |
100 | 99 | ||