diff options
| author | Jeff Dike <jdike@addtoit.com> | 2007-07-16 02:38:56 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-16 12:05:38 -0400 |
| commit | c43990162fc7f9d2f15a12797fdc6f9c0905f704 (patch) | |
| tree | 64f8b776c4807da48971f3c24ca157c5e6ab921f /arch/um/drivers/xterm.c | |
| parent | 42a359e31a0e438b5b978a8f0fecdbd3c86bb033 (diff) | |
uml: simplify helper stack handling
run_helper and run_helper_thread had arguments which were the same in all
callers. run_helper's stack_out was always NULL and run_helper_thread's
stack_order was always 0. These are now gone, and the constants folded
into the code.
Also fixed leaks of the helper stack in the AIO and SIGIO code.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/um/drivers/xterm.c')
| -rw-r--r-- | arch/um/drivers/xterm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c index 35912846ed21..fd817e541543 100644 --- a/arch/um/drivers/xterm.c +++ b/arch/um/drivers/xterm.c | |||
| @@ -132,7 +132,7 @@ static int xterm_open(int input, int output, int primary, void *d, | |||
| 132 | } | 132 | } |
| 133 | 133 | ||
| 134 | sprintf(title, data->title, data->device); | 134 | sprintf(title, data->title, data->device); |
| 135 | pid = run_helper(NULL, NULL, argv, NULL); | 135 | pid = run_helper(NULL, NULL, argv); |
| 136 | if (pid < 0) { | 136 | if (pid < 0) { |
| 137 | err = pid; | 137 | err = pid; |
| 138 | printk(UM_KERN_ERR "xterm_open : run_helper failed, " | 138 | printk(UM_KERN_ERR "xterm_open : run_helper failed, " |