uml: drivers get release methods

Define release methods for the ubd and net drivers.  They contain as much of
the remove methods as make sense.  All error checking must have already been
done as well as anything else that might be holding a reference on the device
kobject.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 12 insertions, 5 deletions

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 962b8fb35f80..83189e188c3f 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -622,6 +622,14 @@ static int ubd_open_dev(struct ubd *ubd_dev)
         return(err);
 }
 
+static void ubd_device_release(struct device *dev)
+{
+        struct ubd *ubd_dev = dev->driver_data;
+
+        blk_cleanup_queue(ubd_dev->queue);
+        *ubd_dev = ((struct ubd) DEFAULT_UBD);
+}
+
 static int ubd_disk_register(int major, u64 size, int unit,
                              struct gendisk **disk_out)
 {
@@ -644,6 +652,8 @@ static int ubd_disk_register(int major, u64 size, int unit,
         if (major == MAJOR_NR) {
                 ubd_devs[unit].pdev.id   = unit;
                 ubd_devs[unit].pdev.name = DRIVER_NAME;
+                ubd_devs[unit].pdev.dev.release = ubd_device_release;
+                ubd_devs[unit].pdev.dev.driver_data = &ubd_devs[unit];
                 platform_device_register(&ubd_devs[unit].pdev);
                 disk->driverfs_dev = &ubd_devs[unit].pdev.dev;
         }
@@ -787,7 +797,7 @@ static int ubd_id(char **str, int *start_out, int *end_out)
 
 static int ubd_remove(int n, char **error_out)
 {
-        struct gendisk *disk;
+        struct gendisk *disk = ubd_gendisk[n];
         struct ubd *ubd_dev;
         int err = -ENODEV;
 
@@ -803,7 +813,6 @@ static int ubd_remove(int n, char **error_out)
         if(ubd_dev->count > 0)
                 goto out;
 
-        disk = ubd_gendisk[n];
         ubd_gendisk[n] = NULL;
         if(disk != NULL){
                 del_gendisk(disk);
@@ -816,10 +825,8 @@ static int ubd_remove(int n, char **error_out)
                 fake_gendisk[n] = NULL;
         }
 
-        blk_cleanup_queue(ubd_dev->queue);
-        platform_device_unregister(&ubd_dev->pdev);
-        *ubd_dev = ((struct ubd) DEFAULT_UBD);
         err = 0;
+        platform_device_unregister(&ubd_dev->pdev);
 out:
         mutex_unlock(&ubd_lock);
         return err;