diff options
author | Kautuk Consul <consul.kautuk@gmail.com> | 2012-03-31 08:05:39 -0400 |
---|---|---|
committer | Chris Metcalf <cmetcalf@tilera.com> | 2012-05-25 12:48:29 -0400 |
commit | 4ce6bea220f1a40aba928bd5624ada833ee1c52b (patch) | |
tree | 39850830736916febb5b97741788d17955c9d5af /arch/tile | |
parent | c6f696f69ab352b17f5c97f721e646b53b91f643 (diff) |
tile/mm/fault.c: Port OOM changes to handle_page_fault
Commit d065bd810b6deb67d4897a14bfe21f8eb526ba99
(mm: retry page fault when blocking on disk transfer) and
commit 37b23e0525d393d48a7d59f870b3bc061a30ccdb
(x86,mm: make pagefault killable)
The above commits introduced changes into the x86 pagefault handler
for making the page fault handler retryable as well as killable.
These changes reduce the mmap_sem hold time, which is crucial
during OOM killer invocation.
Port these changes to tile.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
[cmetcalf@tilera.com: initialize "flags" after "write" updated.]
Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Diffstat (limited to 'arch/tile')
-rw-r--r-- | arch/tile/mm/fault.c | 32 |
1 files changed, 27 insertions, 5 deletions
diff --git a/arch/tile/mm/fault.c b/arch/tile/mm/fault.c index 54f18fc25ed0..84ce7abbf5af 100644 --- a/arch/tile/mm/fault.c +++ b/arch/tile/mm/fault.c | |||
@@ -273,11 +273,15 @@ static int handle_page_fault(struct pt_regs *regs, | |||
273 | int si_code; | 273 | int si_code; |
274 | int is_kernel_mode; | 274 | int is_kernel_mode; |
275 | pgd_t *pgd; | 275 | pgd_t *pgd; |
276 | unsigned int flags; | ||
276 | 277 | ||
277 | /* on TILE, protection faults are always writes */ | 278 | /* on TILE, protection faults are always writes */ |
278 | if (!is_page_fault) | 279 | if (!is_page_fault) |
279 | write = 1; | 280 | write = 1; |
280 | 281 | ||
282 | flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE | | ||
283 | (write ? FAULT_FLAG_WRITE : 0)); | ||
284 | |||
281 | is_kernel_mode = (EX1_PL(regs->ex1) != USER_PL); | 285 | is_kernel_mode = (EX1_PL(regs->ex1) != USER_PL); |
282 | 286 | ||
283 | tsk = validate_current(); | 287 | tsk = validate_current(); |
@@ -382,6 +386,8 @@ static int handle_page_fault(struct pt_regs *regs, | |||
382 | vma = NULL; /* happy compiler */ | 386 | vma = NULL; /* happy compiler */ |
383 | goto bad_area_nosemaphore; | 387 | goto bad_area_nosemaphore; |
384 | } | 388 | } |
389 | |||
390 | retry: | ||
385 | down_read(&mm->mmap_sem); | 391 | down_read(&mm->mmap_sem); |
386 | } | 392 | } |
387 | 393 | ||
@@ -429,7 +435,11 @@ good_area: | |||
429 | * make sure we exit gracefully rather than endlessly redo | 435 | * make sure we exit gracefully rather than endlessly redo |
430 | * the fault. | 436 | * the fault. |
431 | */ | 437 | */ |
432 | fault = handle_mm_fault(mm, vma, address, write); | 438 | fault = handle_mm_fault(mm, vma, address, flags); |
439 | |||
440 | if ((fault & VM_FAULT_RETRY) && fatal_signal_pending(current)) | ||
441 | return 0; | ||
442 | |||
433 | if (unlikely(fault & VM_FAULT_ERROR)) { | 443 | if (unlikely(fault & VM_FAULT_ERROR)) { |
434 | if (fault & VM_FAULT_OOM) | 444 | if (fault & VM_FAULT_OOM) |
435 | goto out_of_memory; | 445 | goto out_of_memory; |
@@ -437,10 +447,22 @@ good_area: | |||
437 | goto do_sigbus; | 447 | goto do_sigbus; |
438 | BUG(); | 448 | BUG(); |
439 | } | 449 | } |
440 | if (fault & VM_FAULT_MAJOR) | 450 | if (flags & FAULT_FLAG_ALLOW_RETRY) { |
441 | tsk->maj_flt++; | 451 | if (fault & VM_FAULT_MAJOR) |
442 | else | 452 | tsk->maj_flt++; |
443 | tsk->min_flt++; | 453 | else |
454 | tsk->min_flt++; | ||
455 | if (fault & VM_FAULT_RETRY) { | ||
456 | flags &= ~FAULT_FLAG_ALLOW_RETRY; | ||
457 | |||
458 | /* | ||
459 | * No need to up_read(&mm->mmap_sem) as we would | ||
460 | * have already released it in __lock_page_or_retry | ||
461 | * in mm/filemap.c. | ||
462 | */ | ||
463 | goto retry; | ||
464 | } | ||
465 | } | ||
444 | 466 | ||
445 | #if CHIP_HAS_TILE_DMA() || CHIP_HAS_SN_PROC() | 467 | #if CHIP_HAS_TILE_DMA() || CHIP_HAS_SN_PROC() |
446 | /* | 468 | /* |