arch/tile: Miscellaneous cleanup changes.

This commit is primarily changes caused by reviewing "sparse"
and "checkpatch" output on our sources, so is somewhat noisy, since
things like "printk() -> pr_err()" (or whatever) throughout the
codebase tend to get tedious to read.  Rather than trying to tease
apart precisely which things changed due to which type of code
review, this commit includes various cleanups in the code:

- sparse: Add declarations in headers for globals.
- sparse: Fix __user annotations.
- sparse: Using gfp_t consistently instead of int.
- sparse: removing functions not actually used.
- checkpatch: Clean up printk() warnings by using pr_info(), etc.;
  also avoid partial-line printks except in bootup code.
  - checkpatch: Use exposed structs rather than typedefs.
  - checkpatch: Change some C99 comments to C89 comments.

In addition, a couple of minor other changes are rolled in
to this commit:

- Add support for a "raise" instruction to cause SIGFPE, etc., to be raised.
- Remove some compat code that is unnecessary when we fully eliminate
  some of the deprecated syscalls from the generic syscall ABI.
- Update the tile_defconfig to reflect current config contents.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>

1 files changed, 8 insertions, 8 deletions

diff --git a/arch/tile/kernel/module.c b/arch/tile/kernel/module.c
index ed3e91161f88..e2ab82b7c7e7 100644
--- a/arch/tile/kernel/module.c
+++ b/arch/tile/kernel/module.c
@@ -107,7 +107,7 @@ int apply_relocate(Elf_Shdr *sechdrs,
                    unsigned int relsec,
                    struct module *me)
 {
-        printk(KERN_ERR "module %s: .rel relocation unsupported\n", me->name);
+        pr_err("module %s: .rel relocation unsupported\n", me->name);
         return -ENOEXEC;
 }
 
@@ -119,8 +119,8 @@ int apply_relocate(Elf_Shdr *sechdrs,
 static int validate_hw2_last(long value, struct module *me)
 {
         if (((value << 16) >> 16) != value) {
-                printk("module %s: Out of range HW2_LAST value %#lx\n",
-                       me->name, value);
+                pr_warning("module %s: Out of range HW2_LAST value %#lx\n",
+                           me->name, value);
                 return 0;
         }
         return 1;
@@ -223,10 +223,10 @@ int apply_relocate_add(Elf_Shdr *sechdrs,
                         value -= (unsigned long) location;  /* pc-relative */
                         value = (long) value >> 3;     /* count by instrs */
                         if (!validate_jumpoff(value)) {
-                                printk("module %s: Out of range jump to"
-                                       " %#llx at %#llx (%p)\n", me->name,
-                                       sym->st_value + rel[i].r_addend,
-                                       rel[i].r_offset, location);
+                                pr_warning("module %s: Out of range jump to"
+                                           " %#llx at %#llx (%p)\n", me->name,
+                                           sym->st_value + rel[i].r_addend,
+                                           rel[i].r_offset, location);
                                 return -ENOEXEC;
                         }
                         MUNGE(create_JumpOff_X1);
@@ -236,7 +236,7 @@ int apply_relocate_add(Elf_Shdr *sechdrs,
 #undef MUNGE
 
                 default:
-                        printk(KERN_ERR "module %s: Unknown relocation: %d\n",
+                        pr_err("module %s: Unknown relocation: %d\n",
                                me->name, (int) ELF_R_TYPE(rel[i].r_info));
                         return -ENOEXEC;
                 }