diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2009-03-16 00:10:23 -0400 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2009-03-16 00:10:23 -0400 |
commit | e305cb8f09b6e51940f78516f962ea819bc30ccd (patch) | |
tree | 3cdec425296210cb721d30bc74698f58bc3da1bf /arch/sparc | |
parent | 89229071c049e518668e34b234167d5ed9c94534 (diff) |
cpumask: prepare for iterators to only go to nr_cpu_ids/nr_cpumask_bits.: sparc64
Impact: cleanup, futureproof
In fact, all cpumask ops will only be valid (in general) for bit
numbers < nr_cpu_ids. So use that instead of NR_CPUS in various
places.
This is always safe: no cpu number can be >= nr_cpu_ids, and
nr_cpu_ids is initialized to NR_CPUS at boot.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Mike Travis <travis@sgi.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/sparc')
-rw-r--r-- | arch/sparc/kernel/ds.c | 2 | ||||
-rw-r--r-- | arch/sparc/kernel/irq_64.c | 4 | ||||
-rw-r--r-- | arch/sparc/mm/init_64.c | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c index 57c39843fb2a..90350f838f05 100644 --- a/arch/sparc/kernel/ds.c +++ b/arch/sparc/kernel/ds.c | |||
@@ -653,7 +653,7 @@ static void __cpuinit dr_cpu_data(struct ds_info *dp, | |||
653 | if (cpu_list[i] == CPU_SENTINEL) | 653 | if (cpu_list[i] == CPU_SENTINEL) |
654 | continue; | 654 | continue; |
655 | 655 | ||
656 | if (cpu_list[i] < NR_CPUS) | 656 | if (cpu_list[i] < nr_cpu_ids) |
657 | cpu_set(cpu_list[i], mask); | 657 | cpu_set(cpu_list[i], mask); |
658 | } | 658 | } |
659 | 659 | ||
diff --git a/arch/sparc/kernel/irq_64.c b/arch/sparc/kernel/irq_64.c index 1c378d8e90c5..640631b170ab 100644 --- a/arch/sparc/kernel/irq_64.c +++ b/arch/sparc/kernel/irq_64.c | |||
@@ -265,12 +265,12 @@ static int irq_choose_cpu(unsigned int virt_irq) | |||
265 | spin_lock_irqsave(&irq_rover_lock, flags); | 265 | spin_lock_irqsave(&irq_rover_lock, flags); |
266 | 266 | ||
267 | while (!cpu_online(irq_rover)) { | 267 | while (!cpu_online(irq_rover)) { |
268 | if (++irq_rover >= NR_CPUS) | 268 | if (++irq_rover >= nr_cpu_ids) |
269 | irq_rover = 0; | 269 | irq_rover = 0; |
270 | } | 270 | } |
271 | cpuid = irq_rover; | 271 | cpuid = irq_rover; |
272 | do { | 272 | do { |
273 | if (++irq_rover >= NR_CPUS) | 273 | if (++irq_rover >= nr_cpu_ids) |
274 | irq_rover = 0; | 274 | irq_rover = 0; |
275 | } while (!cpu_online(irq_rover)); | 275 | } while (!cpu_online(irq_rover)); |
276 | 276 | ||
diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 00373ce2d8fb..2c8dfeb7ab04 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c | |||
@@ -1092,7 +1092,7 @@ static void __init numa_parse_mdesc_group_cpus(struct mdesc_handle *md, | |||
1092 | if (strcmp(name, "cpu")) | 1092 | if (strcmp(name, "cpu")) |
1093 | continue; | 1093 | continue; |
1094 | id = mdesc_get_property(md, target, "id", NULL); | 1094 | id = mdesc_get_property(md, target, "id", NULL); |
1095 | if (*id < NR_CPUS) | 1095 | if (*id < nr_cpu_ids) |
1096 | cpu_set(*id, *mask); | 1096 | cpu_set(*id, *mask); |
1097 | } | 1097 | } |
1098 | } | 1098 | } |