[SPARC]: Fix serial console device detection.

The current scheme works on static interpretation of text names, which
is wrong.

The output-device setting, for example, must be resolved via an alias
or similar to a full path name to the console device.

Paths also contain an optional set of 'options', which starts with a
colon at the end of the path.  The option area is used to specify
which of two serial ports ('a' or 'b') the path refers to when a
device node drives multiple ports.  'a' is assumed if the option
specification is missing.

This was caught by the UltraSPARC-T1 simulator.  The 'output-device'
property was set to 'ttya' and we didn't pick upon the fact that this
is an OBP alias set to '/virtual-devices/console'.  Instead we saw it
as the first serial console device, instead of the hypervisor console.

The infrastructure is now there to take advantage of this to resolve
the console correctly even in multi-head situations in fbcon too.

Thanks to Greg Onufer for the bug report.

Signed-off-by: David S. Miller <davem@davemloft.net>

3 files changed, 10 insertions, 87 deletions

diff --git a/arch/sparc64/prom/console.c b/arch/sparc64/prom/console.c
index 7c25c54cefdc..3fafa9a8b50b 100644
--- a/arch/sparc64/prom/console.c
+++ b/arch/sparc64/prom/console.c
@@ -73,88 +73,3 @@ prom_puts(const char *s, int len)
                            P1275_INOUT(3,1),
                            prom_stdout, s, P1275_SIZE(len));
 }
-
-/* Query for input device type */
-enum prom_input_device
-prom_query_input_device(void)
-{
-        int st_p;
-        char propb[64];
-
-        st_p = prom_inst2pkg(prom_stdin);
-        if(prom_node_has_property(st_p, "keyboard"))
-                return PROMDEV_IKBD;
-        prom_getproperty(st_p, "device_type", propb, sizeof(propb));
-        if(strncmp(propb, "serial", 6))
-                return PROMDEV_I_UNK;
-        /* FIXME: Is there any better way how to find out? */   
-        memset(propb, 0, sizeof(propb));
-        st_p = prom_finddevice ("/options");
-        prom_getproperty(st_p, "input-device", propb, sizeof(propb));
-
-        /*
-         * If we get here with propb == 'keyboard', we are on ttya, as
-         * the PROM defaulted to this due to 'no input device'.
-         */
-        if (!strncmp(propb, "keyboard", 8))
-                return PROMDEV_ITTYA;
-
-        if (!strncmp (propb, "rsc", 3))
-                return PROMDEV_IRSC;
-
-        if (!strncmp (propb, "virtual-console", 3))
-                return PROMDEV_IVCONS;
-
-        if (strncmp (propb, "tty", 3) || !propb[3])
-                return PROMDEV_I_UNK;
-
-        switch (propb[3]) {
-                case 'a': return PROMDEV_ITTYA;
-                case 'b': return PROMDEV_ITTYB;
-                default: return PROMDEV_I_UNK;
-        }
-}
-
-/* Query for output device type */
-
-enum prom_output_device
-prom_query_output_device(void)
-{
-        int st_p;
-        char propb[64];
-        int propl;
-
-        st_p = prom_inst2pkg(prom_stdout);
-        propl = prom_getproperty(st_p, "device_type", propb, sizeof(propb));
-        if (propl >= 0 && propl == sizeof("display") &&
-            strncmp("display", propb, sizeof("display")) == 0)
-                return PROMDEV_OSCREEN;
-        if(strncmp("serial", propb, 6))
-                return PROMDEV_O_UNK;
-        /* FIXME: Is there any better way how to find out? */   
-        memset(propb, 0, sizeof(propb));
-        st_p = prom_finddevice ("/options");
-        prom_getproperty(st_p, "output-device", propb, sizeof(propb));
-
-        /*
-         * If we get here with propb == 'screen', we are on ttya, as
-         * the PROM defaulted to this due to 'no input device'.
-         */
-        if (!strncmp(propb, "screen", 6))
-                return PROMDEV_OTTYA;
-
-        if (!strncmp (propb, "rsc", 3))
-                return PROMDEV_ORSC;
-
-        if (!strncmp (propb, "virtual-console", 3))
-                return PROMDEV_OVCONS;
-
-        if (strncmp (propb, "tty", 3) || !propb[3])
-                return PROMDEV_O_UNK;
-
-        switch (propb[3]) {
-                case 'a': return PROMDEV_OTTYA;
-                case 'b': return PROMDEV_OTTYB;
-                default: return PROMDEV_O_UNK;
-        }
-}
diff --git a/arch/sparc64/prom/misc.c b/arch/sparc64/prom/misc.c
index 33c5b7da31e5..68c83ad04ad9 100644
--- a/arch/sparc64/prom/misc.c
+++ b/arch/sparc64/prom/misc.c
@@ -72,7 +72,7 @@ void prom_cmdline(void)
 
         local_irq_save(flags);
 
-        if (!serial_console && prom_palette)
+        if (prom_palette)
                 prom_palette(1);
 
 #ifdef CONFIG_SMP
@@ -85,7 +85,7 @@ void prom_cmdline(void)
         smp_release();
 #endif
 
-        if (!serial_console && prom_palette)
+        if (prom_palette)
                 prom_palette(0);
 
         local_irq_restore(flags);
diff --git a/arch/sparc64/prom/tree.c b/arch/sparc64/prom/tree.c
index 17b7ecfe7ca9..b2c5b12c9818 100644
--- a/arch/sparc64/prom/tree.c
+++ b/arch/sparc64/prom/tree.c
@@ -304,3 +304,11 @@ prom_pathtoinode(const char *path)
         if (node == -1) return 0;
         return node;
 }
+
+int prom_ihandle2path(int handle, char *buffer, int bufsize)
+{
+        return p1275_cmd("instance-to-path",
+                         P1275_ARG(1,P1275_ARG_OUT_BUF)|
+                         P1275_INOUT(3, 1),
+                         handle, buffer, P1275_SIZE(bufsize));
+}