aboutsummaryrefslogtreecommitdiffstats
path: root/arch/sparc64/mm/init.c
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2006-03-06 22:59:50 -0500
committerDavid S. Miller <davem@sunset.davemloft.net>2006-03-20 04:14:20 -0500
commita77754b4d0731321db266c6c60ffcd7c62757da5 (patch)
tree37cc4c6793e2b616791d42ee840e5a007a13eccb /arch/sparc64/mm/init.c
parent9132983ae140a8ca81e95e081d5a4c0dd7a7f670 (diff)
[SPARC64]: Bulletproof MMU context locking.
1) Always spin_lock_init() in init_context(). The caller essentially clears it out, or copies the mm info from the parent. In both cases we need to explicitly initialize the spinlock. 2) Always do explicit IRQ disabling while taking mm->context.lock and ctx_alloc_lock. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc64/mm/init.c')
-rw-r--r--arch/sparc64/mm/init.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/arch/sparc64/mm/init.c b/arch/sparc64/mm/init.c
index 9bbd0bf64af0..a63939347b3d 100644
--- a/arch/sparc64/mm/init.c
+++ b/arch/sparc64/mm/init.c
@@ -639,9 +639,10 @@ void get_new_mmu_context(struct mm_struct *mm)
639{ 639{
640 unsigned long ctx, new_ctx; 640 unsigned long ctx, new_ctx;
641 unsigned long orig_pgsz_bits; 641 unsigned long orig_pgsz_bits;
642 unsigned long flags;
642 int new_version; 643 int new_version;
643 644
644 spin_lock(&ctx_alloc_lock); 645 spin_lock_irqsave(&ctx_alloc_lock, flags);
645 orig_pgsz_bits = (mm->context.sparc64_ctx_val & CTX_PGSZ_MASK); 646 orig_pgsz_bits = (mm->context.sparc64_ctx_val & CTX_PGSZ_MASK);
646 ctx = (tlb_context_cache + 1) & CTX_NR_MASK; 647 ctx = (tlb_context_cache + 1) & CTX_NR_MASK;
647 new_ctx = find_next_zero_bit(mmu_context_bmap, 1 << CTX_NR_BITS, ctx); 648 new_ctx = find_next_zero_bit(mmu_context_bmap, 1 << CTX_NR_BITS, ctx);
@@ -677,7 +678,7 @@ void get_new_mmu_context(struct mm_struct *mm)
677out: 678out:
678 tlb_context_cache = new_ctx; 679 tlb_context_cache = new_ctx;
679 mm->context.sparc64_ctx_val = new_ctx | orig_pgsz_bits; 680 mm->context.sparc64_ctx_val = new_ctx | orig_pgsz_bits;
680 spin_unlock(&ctx_alloc_lock); 681 spin_unlock_irqrestore(&ctx_alloc_lock, flags);
681 682
682 if (unlikely(new_version)) 683 if (unlikely(new_version))
683 smp_new_mmu_context_version(); 684 smp_new_mmu_context_version();