diff options
author | David S. Miller <davem@sunset.davemloft.net> | 2007-05-08 21:25:14 -0400 |
---|---|---|
committer | David S. Miller <davem@sunset.davemloft.net> | 2007-05-08 21:25:14 -0400 |
commit | 127cda1e8cc282de1ca7a9dcc3866841977b9fcc (patch) | |
tree | 800169fa92dc96160044d914ca1ca9fea60339ea /arch/sparc64/mm/fault.c | |
parent | 6c1142602c9c8faedbc1321892a169652a173fc7 (diff) |
[SPARC64]: Optimize fault kprobe handling just like powerpc.
And eliminate DIE_GPF while we're at it.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc64/mm/fault.c')
-rw-r--r-- | arch/sparc64/mm/fault.c | 45 |
1 files changed, 14 insertions, 31 deletions
diff --git a/arch/sparc64/mm/fault.c b/arch/sparc64/mm/fault.c index c32e309f7788..b582024d2199 100644 --- a/arch/sparc64/mm/fault.c +++ b/arch/sparc64/mm/fault.c | |||
@@ -32,36 +32,23 @@ | |||
32 | #include <asm/mmu_context.h> | 32 | #include <asm/mmu_context.h> |
33 | 33 | ||
34 | #ifdef CONFIG_KPROBES | 34 | #ifdef CONFIG_KPROBES |
35 | ATOMIC_NOTIFIER_HEAD(notify_page_fault_chain); | 35 | static inline int notify_page_fault(struct pt_regs *regs) |
36 | |||
37 | /* Hook to register for page fault notifications */ | ||
38 | int register_page_fault_notifier(struct notifier_block *nb) | ||
39 | { | 36 | { |
40 | return atomic_notifier_chain_register(¬ify_page_fault_chain, nb); | 37 | int ret = 0; |
41 | } | 38 | |
42 | 39 | /* kprobe_running() needs smp_processor_id() */ | |
43 | int unregister_page_fault_notifier(struct notifier_block *nb) | 40 | if (!user_mode(regs)) { |
44 | { | 41 | preempt_disable(); |
45 | return atomic_notifier_chain_unregister(¬ify_page_fault_chain, nb); | 42 | if (kprobe_running() && kprobe_fault_handler(regs, 0)) |
46 | } | 43 | ret = 1; |
47 | 44 | preempt_enable(); | |
48 | static inline int notify_page_fault(enum die_val val, const char *str, | 45 | } |
49 | struct pt_regs *regs, long err, int trap, int sig) | 46 | return ret; |
50 | { | ||
51 | struct die_args args = { | ||
52 | .regs = regs, | ||
53 | .str = str, | ||
54 | .err = err, | ||
55 | .trapnr = trap, | ||
56 | .signr = sig | ||
57 | }; | ||
58 | return atomic_notifier_call_chain(¬ify_page_fault_chain, val, &args); | ||
59 | } | 47 | } |
60 | #else | 48 | #else |
61 | static inline int notify_page_fault(enum die_val val, const char *str, | 49 | static inline int notify_page_fault(struct pt_regs *regs) |
62 | struct pt_regs *regs, long err, int trap, int sig) | ||
63 | { | 50 | { |
64 | return NOTIFY_DONE; | 51 | return 0; |
65 | } | 52 | } |
66 | #endif | 53 | #endif |
67 | 54 | ||
@@ -120,9 +107,6 @@ static void __kprobes unhandled_fault(unsigned long address, | |||
120 | printk(KERN_ALERT "tsk->{mm,active_mm}->pgd = %016lx\n", | 107 | printk(KERN_ALERT "tsk->{mm,active_mm}->pgd = %016lx\n", |
121 | (tsk->mm ? (unsigned long) tsk->mm->pgd : | 108 | (tsk->mm ? (unsigned long) tsk->mm->pgd : |
122 | (unsigned long) tsk->active_mm->pgd)); | 109 | (unsigned long) tsk->active_mm->pgd)); |
123 | if (notify_die(DIE_GPF, "general protection fault", regs, | ||
124 | 0, 0, SIGSEGV) == NOTIFY_STOP) | ||
125 | return; | ||
126 | die_if_kernel("Oops", regs); | 110 | die_if_kernel("Oops", regs); |
127 | } | 111 | } |
128 | 112 | ||
@@ -299,8 +283,7 @@ asmlinkage void __kprobes do_sparc64_fault(struct pt_regs *regs) | |||
299 | 283 | ||
300 | fault_code = get_thread_fault_code(); | 284 | fault_code = get_thread_fault_code(); |
301 | 285 | ||
302 | if (notify_page_fault(DIE_PAGE_FAULT, "page_fault", regs, | 286 | if (notify_page_fault(regs)) |
303 | fault_code, 0, SIGSEGV) == NOTIFY_STOP) | ||
304 | return; | 287 | return; |
305 | 288 | ||
306 | si_code = SEGV_MAPERR; | 289 | si_code = SEGV_MAPERR; |