aboutsummaryrefslogtreecommitdiffstats
path: root/arch/sparc64/lib/NGmemcpy.S
diff options
context:
space:
mode:
authorDavid S. Miller <davem@sunset.davemloft.net>2007-03-19 16:27:33 -0400
committerDavid S. Miller <davem@sunset.davemloft.net>2007-03-19 16:27:33 -0400
commit24d559cac4d741d60ec85e927974408020a2f060 (patch)
treee01419724e2da6c817d525756e92d584d41c03eb /arch/sparc64/lib/NGmemcpy.S
parent5851fadce8824d5d4b8fd02c22ae098401f6489e (diff)
[SPARC64]: store-init needs trailing membar.
The manual says that it is required and we actually have crash reports where loads see stale data due to not having membars here. In one case the networking does: memset(skb, 0, offsetof(struct sk_buff, truesize)); and then some code later checks skb->nohdr for zero, but it's still the value that was there before the memset(). Note that arch/sparc64/lib/xor.S already got this right. Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc64/lib/NGmemcpy.S')
-rw-r--r--arch/sparc64/lib/NGmemcpy.S2
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/sparc64/lib/NGmemcpy.S b/arch/sparc64/lib/NGmemcpy.S
index 8e522b3dc095..66063a9a66b8 100644
--- a/arch/sparc64/lib/NGmemcpy.S
+++ b/arch/sparc64/lib/NGmemcpy.S
@@ -247,6 +247,8 @@ FUNC_NAME: /* %o0=dst, %o1=src, %o2=len */
247 /* fall through */ 247 /* fall through */
248 248
24960: 24960:
250 membar #Sync
251
250 /* %o2 contains any final bytes still needed to be copied 252 /* %o2 contains any final bytes still needed to be copied
251 * over. If anything is left, we copy it one byte at a time. 253 * over. If anything is left, we copy it one byte at a time.
252 */ 254 */