diff options
author | Dan McGee <dpmcgee@gmail.com> | 2011-10-17 09:05:23 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2011-11-27 19:42:09 -0500 |
commit | fa8cbaaf5a68f62db3f9a8444ecbb940b47984cb (patch) | |
tree | ef8c31c149c7f1fb6c504e7556dab3e56212c539 /arch/sparc/kernel/sys_sparc_64.c | |
parent | 3ce21cdfe93efffa4ffba9cf3ca2576d3d60d6dc (diff) |
powerpc+sparc64/mm: Remove hack in mmap randomize layout
Since commit 8a0a9bd4db63bc45e301, this comment in mmap_rnd() does not
hold true as the value returned by get_random_int() will in fact be
different every single call. Remove the comment and simplify the code
back to its original desired form.
This reverts commit a5adc91a4b44b5d1 which is no longer necessary and
also fixes the sparc code that copied this same adjustment.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Diffstat (limited to 'arch/sparc/kernel/sys_sparc_64.c')
-rw-r--r-- | arch/sparc/kernel/sys_sparc_64.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/sparc/kernel/sys_sparc_64.c b/arch/sparc/kernel/sys_sparc_64.c index 441521ad8a3f..232df9949530 100644 --- a/arch/sparc/kernel/sys_sparc_64.c +++ b/arch/sparc/kernel/sys_sparc_64.c | |||
@@ -368,11 +368,11 @@ static unsigned long mmap_rnd(void) | |||
368 | if (current->flags & PF_RANDOMIZE) { | 368 | if (current->flags & PF_RANDOMIZE) { |
369 | unsigned long val = get_random_int(); | 369 | unsigned long val = get_random_int(); |
370 | if (test_thread_flag(TIF_32BIT)) | 370 | if (test_thread_flag(TIF_32BIT)) |
371 | rnd = (val % (1UL << (22UL-PAGE_SHIFT))); | 371 | rnd = (val % (1UL << (23UL-PAGE_SHIFT))); |
372 | else | 372 | else |
373 | rnd = (val % (1UL << (29UL-PAGE_SHIFT))); | 373 | rnd = (val % (1UL << (30UL-PAGE_SHIFT))); |
374 | } | 374 | } |
375 | return (rnd << PAGE_SHIFT) * 2; | 375 | return rnd << PAGE_SHIFT; |
376 | } | 376 | } |
377 | 377 | ||
378 | void arch_pick_mmap_layout(struct mm_struct *mm) | 378 | void arch_pick_mmap_layout(struct mm_struct *mm) |