diff options
author | Sam Ravnborg <sam@ravnborg.org> | 2011-01-03 03:27:55 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-01-03 15:15:12 -0500 |
commit | 5f66dd35b49ea81a03e71bfd74c28364f4e32d21 (patch) | |
tree | 0d4989b00ba4976852f57bac51ca2d9b4eb13735 /arch/sparc/include/asm/oplib_32.h | |
parent | 1f42be484ffc5559a29466c82adac7dd472d4439 (diff) |
sparc: fix sparse warnings in arch/sparc/prom for 32 bit build
Fix following sparse warnings:
arch/sparc/prom/bootstr_32.c:32:35: warning: Using plain integer as NULL pointer
arch/sparc/prom/memory.c:61:13: warning: symbol 'prom_meminit' was not declared. Should it be static?
arch/sparc/prom/misc_32.c:74:1: error: symbol 'prom_halt' redeclared with different type (originally declared at arch/sparc/include/asm/oplib_32.h:67) - different modifiers
arch/sparc/prom/ranges.c:16:26: warning: symbol 'promlib_obio_ranges' was not declared. Should it be static?
arch/sparc/prom/ranges.c:17:5: warning: symbol 'num_obio_ranges' was not declared. Should it be static?
arch/sparc/prom/ranges.c:39:1: warning: symbol 'prom_adjust_ranges' was not declared. Should it be static?
arch/sparc/prom/ranges.c:69:13: warning: symbol 'prom_ranges_init' was not declared. Should it be static?
arch/sparc/prom/tree_32.c:286:22: warning: Using plain integer as NULL pointer
arch/sparc/prom/tree_32.c:286:38: warning: Using plain integer as NULL pointer
None of the warnings indicated any serious issues.
We are now sparse clean for 32 bit build in arch/sparc/prom.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc/include/asm/oplib_32.h')
-rw-r--r-- | arch/sparc/include/asm/oplib_32.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/arch/sparc/include/asm/oplib_32.h b/arch/sparc/include/asm/oplib_32.h index 98f70822fa05..71e5e9aeb67e 100644 --- a/arch/sparc/include/asm/oplib_32.h +++ b/arch/sparc/include/asm/oplib_32.h | |||
@@ -64,7 +64,7 @@ extern void prom_cmdline(void); | |||
64 | /* Enter the prom, with no chance of continuation for the stand-alone | 64 | /* Enter the prom, with no chance of continuation for the stand-alone |
65 | * which calls this. | 65 | * which calls this. |
66 | */ | 66 | */ |
67 | extern void prom_halt(void) __attribute__ ((noreturn)); | 67 | extern void __noreturn prom_halt(void); |
68 | 68 | ||
69 | /* Set the PROM 'sync' callback function to the passed function pointer. | 69 | /* Set the PROM 'sync' callback function to the passed function pointer. |
70 | * When the user gives the 'sync' command at the prom prompt while the | 70 | * When the user gives the 'sync' command at the prom prompt while the |
@@ -113,6 +113,8 @@ extern int prom_startcpu(int cpunode, struct linux_prom_registers *context_table | |||
113 | extern void prom_putsegment(int context, unsigned long virt_addr, | 113 | extern void prom_putsegment(int context, unsigned long virt_addr, |
114 | int physical_segment); | 114 | int physical_segment); |
115 | 115 | ||
116 | /* Initialize the memory lists based upon the prom version. */ | ||
117 | void prom_meminit(void); | ||
116 | 118 | ||
117 | /* PROM device tree traversal functions... */ | 119 | /* PROM device tree traversal functions... */ |
118 | 120 | ||
@@ -177,6 +179,8 @@ extern void prom_apply_obio_ranges(struct linux_prom_registers *obioregs, int nr | |||
177 | extern void prom_apply_generic_ranges(phandle node, phandle parent, | 179 | extern void prom_apply_generic_ranges(phandle node, phandle parent, |
178 | struct linux_prom_registers *sbusregs, int nregs); | 180 | struct linux_prom_registers *sbusregs, int nregs); |
179 | 181 | ||
182 | void prom_ranges_init(void); | ||
183 | |||
180 | /* CPU probing helpers. */ | 184 | /* CPU probing helpers. */ |
181 | int cpu_find_by_instance(int instance, phandle *prom_node, int *mid); | 185 | int cpu_find_by_instance(int instance, phandle *prom_node, int *mid); |
182 | int cpu_find_by_mid(int mid, phandle *prom_node); | 186 | int cpu_find_by_mid(int mid, phandle *prom_node); |